Page MenuHomePhabricator

Remove deprecated comment-related Linker functions in 1.42
Open, LowPublic

Description

Replace usage of deprecated comment related functions:

  • Linker::formatComment
  • Linker::formatLinksInComment
  • Linker::commentBlock
  • Linker::revComment

The deprecation has happen in 1.38. Use the new CommentFormatter service.

CodeSearch: https://codesearch.wmcloud.org/search/?q=%5CbLinker%5Cs*%3A%3A%5Cs*(formatComment%7CformatLinksInComment%7CcommentBlock%7CrevComment)%5Cb&i=nope&files=&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
mediawiki/coremaster+14 -4
mediawiki/extensions/Echomaster+1 -2
mediawiki/extensions/SocialProfilemaster+4 -2
mediawiki/extensions/ArticleFeedbackv5master+9 -5
mediawiki/extensions/GlobalContribsmaster+3 -2
mediawiki/extensions/ChangeAuthorREL1_39+4 -2
mediawiki/extensions/WatchAnalyticsmaster+15 -1
mediawiki/extensions/Videomaster+26 -4
mediawiki/extensions/MassEditRegexmaster+3 -2
mediawiki/coremaster+62 -22
mediawiki/extensions/Echomaster+5 -3
mediawiki/extensions/LiquidThreadsmaster+5 -5
mediawiki/extensions/ApprovedRevsmaster+8 -1
mediawiki/extensions/ChangeAuthormaster+4 -2
mediawiki/coremaster+20 -9
mediawiki/coremaster+75 -13
mediawiki/extensions/RevisionCommentSupplementmaster+81 -20
mediawiki/extensions/EventBusmaster+13 -6
mediawiki/extensions/Flowmaster+8 -7
mediawiki/coremaster+17 -2
mediawiki/extensions/Thanksmaster+2 -2
mediawiki/extensions/GlobalBlockingmaster+49 -10
mediawiki/extensions/MassMessagemaster+8 -7
mediawiki/extensions/MobileFrontendmaster+2 -1
mediawiki/coremaster+9 -4
mediawiki/extensions/TwoColConflictmaster+28 -5
mediawiki/extensions/Wikibasemaster+29 -10
mediawiki/extensions/ThrottleOverridemaster+1 -1
mediawiki/extensions/GlobalContributionsmaster+0 -2
mediawiki/coremaster+6 -12
mediawiki/extensions/CentralAuthmaster+11 -4
mediawiki/extensions/FileImportermaster+1 -1
mediawiki/extensions/AbuseFiltermaster+5 -2
mediawiki/extensions/CheckUsermaster+21 -5
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 866670 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] Replace deprecated Linker::commentBlock

https://gerrit.wikimedia.org/r/866670

Change 866671 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ApprovedRevs@master] Replace deprecated Linker::revComment

https://gerrit.wikimedia.org/r/866671

Change 866672 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralAuth@master] Replace deprecated Linker::formatLinksInComment

https://gerrit.wikimedia.org/r/866672

Change 866673 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CheckUser@master] Replace deprecated Linker::commentBlock

https://gerrit.wikimedia.org/r/866673

Change 866674 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Echo@master] Replace deprecated Linker::formatComment/formatLinksInComment

https://gerrit.wikimedia.org/r/866674

Change 866675 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GlobalBlocking@master] Replace deprecated Linker::commentBlock

https://gerrit.wikimedia.org/r/866675

Change 866677 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Thanks@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866677

Change 866678 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ThrottleOverride@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866678

Change 866679 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866679

Change 866680 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MassMessage@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866680

Change 866681 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TwoColConflict@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866681

Change 866682 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MassEditRegex@master] Replace deprecated Linker::commentBlock

https://gerrit.wikimedia.org/r/866682

Change 866683 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GlobalContribs@master] Replace deprecated Linker::revComment

https://gerrit.wikimedia.org/r/866683

Change 866685 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ChangeAuthor@master] Replace deprecated Linker::commentBlock

https://gerrit.wikimedia.org/r/866685

Change 866706 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SocialProfile@master] Replace deprecated Linker::revComment

https://gerrit.wikimedia.org/r/866706

Change 866707 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MobileFrontend@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866707

Change 866708 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ArticleFeedbackv5@master] Replace deprecated Linker::commentBlock/formatComment

https://gerrit.wikimedia.org/r/866708

Change 866709 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Video@master] Replace deprecated Linker::revComment/commentBlock

https://gerrit.wikimedia.org/r/866709

Change 866710 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WatchAnalytics@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866710

Change 866711 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Flow@master] Replace deprecated Linker::commentBlock/formatLinksInComment

https://gerrit.wikimedia.org/r/866711

Change 866712 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LiquidThreads@master] Replace deprecated Linker::commentBlock/formatLinksInComment

https://gerrit.wikimedia.org/r/866712

Change 866713 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/EventBus@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866713

Change 866714 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/RevisionCommentSupplement@master] Replace deprecated Linker::formatComment/revComment

https://gerrit.wikimedia.org/r/866714

Change 866673 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Replace deprecated Linker::commentBlock

https://gerrit.wikimedia.org/r/866673

Change 866715 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FileImporter@master] Replace comment about deprecated Linker::formatLinksInComment

https://gerrit.wikimedia.org/r/866715

Change 866716 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GlobalContributions@master] Remove dead code with deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866716

Change 866717 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866717

Change 866718 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] actions: Replace deprecated Linker::commentBlock

https://gerrit.wikimedia.org/r/866718

Change 866719 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] specials: Replace deprecated Linker::revComment/formatComment/Block

https://gerrit.wikimedia.org/r/866719

Change 866720 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Replace deprecated Linker::commentBlock/revComment

https://gerrit.wikimedia.org/r/866720

Umherirrender renamed this task from Replace and remove deprecated comment-related Linker functions to Replace, hard-deprecate and remove deprecated comment-related Linker functions.Dec 11 2022, 12:40 AM
Umherirrender triaged this task as Low priority.

Change 866721 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] revisionslists: Replace deprecated Linker::revComment/commentBlock

https://gerrit.wikimedia.org/r/866721

Change 866723 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Replace comments about deprecated Linker::commentBlock/formatComment

https://gerrit.wikimedia.org/r/866723

Change 866670 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Replace deprecated Linker::commentBlock

https://gerrit.wikimedia.org/r/866670

Change 866715 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Replace comment about deprecated Linker::formatLinksInComment

https://gerrit.wikimedia.org/r/866715

Change 866672 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Replace deprecated Linker::formatLinksInComment

https://gerrit.wikimedia.org/r/866672

Change 866723 merged by jenkins-bot:

[mediawiki/core@master] Replace comments about deprecated Linker::commentBlock/formatComment

https://gerrit.wikimedia.org/r/866723

Change 866716 merged by jenkins-bot:

[mediawiki/extensions/GlobalContributions@master] Remove dead code with deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866716

Change 866679 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866679

Change 866681 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866681

Change 866707 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866707

Change 866680 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866680

Change 866677 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866677

Change 866678 merged by jenkins-bot:

[mediawiki/extensions/ThrottleOverride@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866678

Change 866675 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Replace deprecated Linker::commentBlock

https://gerrit.wikimedia.org/r/866675

Change 866721 merged by jenkins-bot:

[mediawiki/core@master] revisionslists: Replace deprecated Linker::revComment/commentBlock

https://gerrit.wikimedia.org/r/866721

Change 866718 merged by jenkins-bot:

[mediawiki/core@master] actions: Replace deprecated Linker::commentBlock

https://gerrit.wikimedia.org/r/866718

Change 866719 merged by jenkins-bot:

[mediawiki/core@master] specials: Replace deprecated Linker::revComment/formatComment/Block

https://gerrit.wikimedia.org/r/866719

Change 866711 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Replace deprecated Linker::commentBlock/formatLinksInComment

https://gerrit.wikimedia.org/r/866711

Change 866713 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866713

Change 866720 merged by jenkins-bot:

[mediawiki/core@master] Replace deprecated Linker::commentBlock/revComment

https://gerrit.wikimedia.org/r/866720

Change 866714 merged by jenkins-bot:

[mediawiki/extensions/RevisionCommentSupplement@master] Replace deprecated Linker::formatComment/revComment

https://gerrit.wikimedia.org/r/866714

Change 866685 merged by jenkins-bot:

[mediawiki/extensions/ChangeAuthor@master] Replace deprecated Linker::commentBlock

https://gerrit.wikimedia.org/r/866685

Change 866671 merged by jenkins-bot:

[mediawiki/extensions/ApprovedRevs@master] Replace deprecated Linker::revComment

https://gerrit.wikimedia.org/r/866671

Change 866712 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Replace deprecated Linker::commentBlock/formatLinksInComment

https://gerrit.wikimedia.org/r/866712

Change 866674 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Replace deprecated Linker::formatComment/formatLinksInComment

https://gerrit.wikimedia.org/r/866674

Change 866717 merged by jenkins-bot:

[mediawiki/core@master] api: Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866717

Change 866682 merged by jenkins-bot:

[mediawiki/extensions/MassEditRegex@master] Replace deprecated Linker::commentBlock

https://gerrit.wikimedia.org/r/866682

Change 866709 merged by Umherirrender:

[mediawiki/extensions/Video@master] Replace deprecated Linker::revComment/commentBlock

https://gerrit.wikimedia.org/r/866709

Change 866710 merged by Umherirrender:

[mediawiki/extensions/WatchAnalytics@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/866710

Change 883626 had a related patch set uploaded (by Brian Wolff; author: Umherirrender):

[mediawiki/extensions/ChangeAuthor@REL1_39] Replace deprecated Linker::commentBlock

https://gerrit.wikimedia.org/r/883626

Change 883626 merged by jenkins-bot:

[mediawiki/extensions/ChangeAuthor@REL1_39] Replace deprecated Linker::commentBlock

https://gerrit.wikimedia.org/r/883626

Change 866683 merged by jenkins-bot:

[mediawiki/extensions/GlobalContribs@master] Replace deprecated Linker::revComment

https://gerrit.wikimedia.org/r/866683

Change 866708 merged by jenkins-bot:

[mediawiki/extensions/ArticleFeedbackv5@master] Replace deprecated Linker::commentBlock/formatComment

https://gerrit.wikimedia.org/r/866708

Change 866706 merged by jenkins-bot:

[mediawiki/extensions/SocialProfile@master] Replace deprecated Linker::revComment

https://gerrit.wikimedia.org/r/866706

Change 945672 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Echo@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/945672

Change 945672 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Replace deprecated Linker::formatComment

https://gerrit.wikimedia.org/r/945672

Change 946636 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Hard-deprecate Linker::formatComment/commentBlock/revComment

https://gerrit.wikimedia.org/r/946636

Change 946636 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate Linker::formatComment/commentBlock/revComment

https://gerrit.wikimedia.org/r/946636

Umherirrender renamed this task from Replace, hard-deprecate and remove deprecated comment-related Linker functions to Remove deprecated comment-related Linker functions in 1.42.Aug 16 2023, 1:12 AM
Umherirrender changed the task status from Open to Stalled.
Umherirrender removed Umherirrender as the assignee of this task.
Umherirrender changed the task status from Stalled to Open.Oct 13 2023, 3:47 PM