Page MenuHomePhabricator

diffs with a suppressed revision does not show a double-striked timestamp
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Suppress the content of an old revision
  • Diff the revision using a priviliged user
  • The timestamp of the suppressed revision is styled as "double-striked" (by using mw-history-suppressed)
  • Now visit the diff with an unpriviliged user
  • The timestamp of the suppressed revision is only single-striked (mw-history-suppressed is missing)
  • The timestamp is also linked to the oldid, but that is not helpful.
  • Compare with action=history where the timestamp is double-striked and no link is provided, when the oldid is not viewable by the current user

What should have happened instead?:
Should look similiar to action=history

Event Timeline

Change 868798 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] diff: Handle timestamp correct for suppressed revisions

https://gerrit.wikimedia.org/r/868798

Change 868798 merged by jenkins-bot:

[mediawiki/core@master] diff: Handle timestamp correct for suppressed revisions

https://gerrit.wikimedia.org/r/868798