Page MenuHomePhabricator
Create Task
Maniphest T325673

Hard-deprecate UserGroupMembership::getGroupName/getGroupMemberName function (and remove in 1.42)
Closed, ResolvedPublic
Actions

Description

The function UserGroupMembership::getGroupName was deprecated in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/730631

The function UserGroupMembership::getGroupMemberName was prepared similiar for deprecation, but not deprecated in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/731163

Should be hard-deprecated and removed

https://codesearch.wmcloud.org/search/?q=%5CbUserGroupMembership%5Cs*%3A%3A%5Cs*(getGroupName%7CgetGroupMemberName)%5Cb&i=nope&files=&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
Drop hard-deprecated UserGroupMembership::getGroupName/getGroupMemberNamemediawiki/coremaster+3 -29
Hard-deprecate UserGroupMembership::getGroupName/getGroupMemberNamemediawiki/coremaster+7 -2
Replace deprecated UserGroupMembership::getGroupNamemediawiki/extensions/PageOwnershipmaster+12 -1
Replace deprecated UserGroupMembership::getGroupMemberNamemediawiki/extensions/InviteSignupmaster+14 -3
Replace deprecated UserGroupMembership::getGroupMemberNamemediawiki/extensions/BatchUserRightsmaster+14 -2
user: Deprecate UserGroupMembership::getGroupMemberNamemediawiki/coremaster+10 -0
user: Replace deprecated UserGroupMembership::getGroupNamemediawiki/coremaster+3 -3
Replace deprecated UserGroupMembership::getGroupNamemediawiki/extensions/CentralAuthmaster+6 -5
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Dec 20 2022, 7:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2022, 7:13 PM
gerritbot added a comment.Dec 20 2022, 7:14 PM

Change 869839 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] user: Replace deprecated UserGroupMembership::getGroupName

https://gerrit.wikimedia.org/r/869839

gerritbot added a project: Patch-For-Review.Dec 20 2022, 7:14 PM
gerritbot added a comment.Dec 20 2022, 7:20 PM

Change 869841 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralAuth@master] Replace deprecated UserGroupMembership::getGroupName

https://gerrit.wikimedia.org/r/869841

gerritbot added a comment.Dec 20 2022, 7:25 PM

Change 869843 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageOwnership@master] Replace deprecated UserGroupMembership::getGroupName

https://gerrit.wikimedia.org/r/869843

Umherirrender renamed this task from Hard-deprecate UserGroupMembership::getGroupName function (and remove a release later) to Hard-deprecate UserGroupMembership::getGroupName/getGroupMemberName function (and remove a release later).Dec 20 2022, 7:30 PM
Umherirrender updated the task description. (Show Details)
gerritbot added a comment.Dec 20 2022, 7:36 PM

Change 869844 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/InviteSignup@master] Replace deprecated UserGroupMembership::getGroupMemberName

https://gerrit.wikimedia.org/r/869844

gerritbot added a comment.Dec 20 2022, 7:39 PM

Change 869846 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BatchUserRights@master] Replace deprecated UserGroupMembership::getGroupMemberName

https://gerrit.wikimedia.org/r/869846

gerritbot added a comment.Dec 20 2022, 7:47 PM

Change 869847 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] user: Deprecate UserGroupMembership::getGroupMemberName

https://gerrit.wikimedia.org/r/869847

Umherirrender moved this task from Untriaged to 2022 | MW 1.38 / 1.39 on the Technical-Debt (Deprecation process) board.Dec 20 2022, 8:01 PM
Umherirrender moved this task from Backlog to Other on the MediaWiki-User-management board.Dec 20 2022, 9:45 PM
gerritbot added a comment.Dec 21 2022, 6:23 AM

Change 869841 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Replace deprecated UserGroupMembership::getGroupName

https://gerrit.wikimedia.org/r/869841

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 21 2022, 7:01 AM
gerritbot added a comment.Dec 21 2022, 7:36 PM

Change 869839 merged by jenkins-bot:

[mediawiki/core@master] user: Replace deprecated UserGroupMembership::getGroupName

https://gerrit.wikimedia.org/r/869839

gerritbot added a comment.Dec 23 2022, 1:59 AM

Change 869847 merged by jenkins-bot:

[mediawiki/core@master] user: Deprecate UserGroupMembership::getGroupMemberName

https://gerrit.wikimedia.org/r/869847

Umherirrender renamed this task from Hard-deprecate UserGroupMembership::getGroupName/getGroupMemberName function (and remove a release later) to Hard-deprecate UserGroupMembership::getGroupName/getGroupMemberName function in 1.41 (and remove a release later).Dec 23 2022, 2:22 PM
Umherirrender changed the task status from Open to Stalled.
gerritbot added a comment.Dec 28 2022, 1:04 AM

Change 869846 merged by jenkins-bot:

[mediawiki/extensions/BatchUserRights@master] Replace deprecated UserGroupMembership::getGroupMemberName

https://gerrit.wikimedia.org/r/869846

gerritbot added a comment.Jan 4 2023, 10:50 AM

Change 869844 merged by jenkins-bot:

[mediawiki/extensions/InviteSignup@master] Replace deprecated UserGroupMembership::getGroupMemberName

https://gerrit.wikimedia.org/r/869844

Umherirrender mentioned this in rEIVS018ef400f4fb: Replace deprecated UserGroupMembership::getGroupMemberName.Jan 4 2023, 10:50 AM
gerritbot added a comment.Jan 6 2023, 3:46 PM

Change 869843 merged by Umherirrender:

[mediawiki/extensions/PageOwnership@master] Replace deprecated UserGroupMembership::getGroupName

https://gerrit.wikimedia.org/r/869843

Umherirrender mentioned this in rEPOW0208175dc49b: Replace deprecated UserGroupMembership::getGroupName.Jan 6 2023, 4:27 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 6 2023, 4:30 PM
Umherirrender changed the task status from Stalled to Open.Mar 14 2023, 9:35 PM
gerritbot added a comment.May 12 2023, 7:41 PM

Change 919399 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Hard-deprecate UserGroupMembership::getGroupName/getGroupMemberName

https://gerrit.wikimedia.org/r/919399

gerritbot added a project: Patch-For-Review.May 12 2023, 7:41 PM
gerritbot added a comment.May 13 2023, 3:12 PM

Change 919399 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate UserGroupMembership::getGroupName/getGroupMemberName

https://gerrit.wikimedia.org/r/919399

Maintenance_bot removed a project: Patch-For-Review.May 13 2023, 3:30 PM
Umherirrender renamed this task from Hard-deprecate UserGroupMembership::getGroupName/getGroupMemberName function in 1.41 (and remove a release later) to Hard-deprecate UserGroupMembership::getGroupName/getGroupMemberName function (and remove in 1.42).May 13 2023, 5:11 PM
Umherirrender changed the task status from Open to Stalled.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 9:01 PM
Umherirrender changed the task status from Stalled to Open.Oct 13 2023, 3:47 PM
gerritbot added a comment.Sun, Apr 21, 7:03 PM

Change #1022607 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/core@master] Drop hard-deprecated UserGroupMembership::getGroupName/getGroupMemberName

https://gerrit.wikimedia.org/r/1022607

gerritbot added a project: Patch-For-Review.Sun, Apr 21, 7:03 PM
taavi claimed this task.Sun, Apr 21, 7:03 PM
gerritbot added a comment.Sun, Apr 21, 8:02 PM

Change #1022607 merged by jenkins-bot:

[mediawiki/core@master] Drop hard-deprecated UserGroupMembership::getGroupName/getGroupMemberName

https://gerrit.wikimedia.org/r/1022607

taavi closed this task as Resolved.Sun, Apr 21, 8:02 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Sun, Apr 21, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 6:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL