Maniphest T325686

Hard-deprecate manual construction of User objects (and enforce @internal a release later)
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Umherirrender
	Dec 20 2022, 9:29 PM

Tags

Referenced Files

None

Subscribers

Description

The manual construction of User objects via new User should not be used, because the constructor is marked as @internal since 1.36.
Use one of the UserFactory::new* methods, for anonymous objects use UserFactory::newAnonymous

CodeSearch: https://codesearch.wmcloud.org/search/?q=%5Cbnew%5Cs%2B%5C%5C%3FUser%5Cb&i=nope&files=&excludeFiles=&repos=

Details

	Subject	Repo	Branch	Lines +/-
	ResourceLoader: Use UserFactory::newAnonymous	mediawiki/core	master	+7 -7
	CentralId: Use UserFactory::newAnonymous	mediawiki/core	master	+41 -13
	Use UserFactory::newAnonymous	mediawiki/core	master	+12 -14
	Output: Use UserFactory::newAnonymous in IframeSandbox	mediawiki/core	master	+11 -4

Customize query in gerrit

Related Objects

Mentioned In: T277511: Drop hard-deprecated User methods once they've been hard-deprecated in at least once release

Event Timeline

Umherirrender created this task.Dec 20 2022, 9:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2022, 9:29 PM

Umherirrender mentioned this in T277511: Drop hard-deprecated User methods once they've been hard-deprecated in at least once release.Dec 20 2022, 9:35 PM

Umherirrender moved this task from Untriaged to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.

Umherirrender moved this task from Backlog to Other on the MediaWiki-User-management board.Dec 20 2022, 9:45 PM

Change 992230 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] ResourceLoader: Use UserFactory::newAnonymous

https://gerrit.wikimedia.org/r/992230

gerritbot added a project: Patch-For-Review.Jan 22 2024, 8:04 PM

Change 992231 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Use UserFactory::newAnonymous

https://gerrit.wikimedia.org/r/992231

Change 992232 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Output: Use UserFactory::newAnonymous in IframeSandbox

https://gerrit.wikimedia.org/r/992232

Change 992233 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] CentralId: Use UserFactory::newAnonymous

https://gerrit.wikimedia.org/r/992233

Change 992231 merged by jenkins-bot:

[mediawiki/core@master] Use UserFactory::newAnonymous

https://gerrit.wikimedia.org/r/992231

Change 992232 merged by jenkins-bot:

[mediawiki/core@master] Output: Use UserFactory::newAnonymous in IframeSandbox

https://gerrit.wikimedia.org/r/992232

Change 992230 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Use UserFactory::newAnonymous

https://gerrit.wikimedia.org/r/992230

Change 992233 merged by jenkins-bot:

[mediawiki/core@master] CentralId: Use UserFactory::newAnonymous

https://gerrit.wikimedia.org/r/992233

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Jan 22 2024, 10:01 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2024, 10:30 PM