Page MenuHomePhabricator
Create Task
Maniphest T325729

[tbs.cli] Add --ref parameter to allow specifying a branch/revision
Closed, ResolvedPublic
Actions

Description

This will help debugging/adopting the buildpacks as it allows to have a branch while checking/testing things.

The parameter should allow a revision to be passed, for example:

# branch
$ toolforge build create https://github.com/david-caro/wm-lol --ref upstream_buildpacks
# tag
$ toolforge build create https://github.com/david-caro/wm-lol --ref v1.0.1
# or a commit
$ toolforge build create https://github.com/david-caro/wm-lol --ref 815e416b1da1819b7f09150e67668f0fbeaa8881

Note that the current pipeline allows passing a parameter 'revision' when creating the pipelinerun that already supports these usecases.

Details

SubjectRepoBranchLines +/-
build: add tag to builder imagecloud/toolforge/toolforge-climain+1 -1
cli: add --ref option to specify branch/tag/commitcloud/toolforge/toolforge-climain+52 -8
tox: remove unnecessary format environmentcloud/toolforge/toolforge-climain+0 -3
tox: Allow passing args to pre-commit to select hookcloud/toolforge/toolforge-climain+2 -1
Customize query in gerrit

Related Objects

Event Timeline

dcaro triaged this task as High priority.Dec 21 2022, 10:50 AM
dcaro created this task.
dcaro added a project: Toolforge Build Service.
dcaro edited projects, added Toolforge Build Service (Iteration 07); removed Toolforge Build Service.Dec 21 2022, 10:52 AM
dcaro changed the task status from Open to In Progress.Dec 21 2022, 10:52 AM
dcaro moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 07) board.
gerritbot added a comment.Dec 22 2022, 3:00 PM

Change 870895 had a related patch set uploaded (by David Caro; author: David Caro):

[cloud/toolforge/toolforge-cli@main] tox: Allow passing args to pre-commit to select hook

https://gerrit.wikimedia.org/r/870895

gerritbot added a project: Patch-For-Review.Dec 22 2022, 3:00 PM

Change 870896 had a related patch set uploaded (by David Caro; author: David Caro):

[cloud/toolforge/toolforge-cli@main] cli: add --ref option to specify branch/tag/commit

https://gerrit.wikimedia.org/r/870896

Slst2020 renamed this task from [tbs.csi] Add --revision parameter to allow specifying a branch/revision to [tbs.cli] Add --revision parameter to allow specifying a branch/revision.Jan 3 2023, 6:11 AM
Raymond_Ndibe moved this task from In Progress to In Review on the Toolforge Build Service (Iteration 07) board.Jan 3 2023, 6:07 PM
gerritbot added a comment.Jan 4 2023, 8:57 AM

Change 870895 merged by jenkins-bot:

[cloud/toolforge/toolforge-cli@main] tox: Allow passing args to pre-commit to select hook

https://gerrit.wikimedia.org/r/870895

dcaro mentioned this in rCTTC420b064b2980: tox: Allow passing args to pre-commit to select hook.Jan 4 2023, 8:58 AM
gerritbot added a comment.Jan 4 2023, 9:07 AM

Change 875261 had a related patch set uploaded (by David Caro; author: David Caro):

[cloud/toolforge/toolforge-cli@main] tox: remove unnecessary format environment

https://gerrit.wikimedia.org/r/875261

gerritbot added a comment.Jan 4 2023, 9:38 AM

Change 875261 merged by jenkins-bot:

[cloud/toolforge/toolforge-cli@main] tox: remove unnecessary format environment

https://gerrit.wikimedia.org/r/875261

dcaro mentioned this in rCTTC71086402d592: tox: remove unnecessary format environment.Jan 4 2023, 9:38 AM
gerritbot added a comment.Jan 6 2023, 3:38 PM

Change 870896 merged by jenkins-bot:

[cloud/toolforge/toolforge-cli@main] cli: add --ref option to specify branch/tag/commit

https://gerrit.wikimedia.org/r/870896

dcaro mentioned this in rCTTC50db5bb8f0cf: cli: add --ref option to specify branch/tag/commit.Jan 6 2023, 3:40 PM
KHernandez-WMF changed the task status from In Progress to Stalled.Jan 10 2023, 2:16 PM
KHernandez-WMF moved this task from In Review to Blocked/Paused on the Toolforge Build Service (Iteration 07) board.
KHernandez-WMF moved this task from Iteration 07 to Iteration 08 on the Toolforge Build Service board.Jan 10 2023, 6:19 PM
KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 08); removed Toolforge Build Service (Iteration 07).
KHernandez-WMF moved this task from Next Up to Blocked/Paused on the Toolforge Build Service (Iteration 08) board.
fnegri edited projects, added cloud-services-team; removed cloud-services-team (Kanban).Jan 18 2023, 6:23 PM
fnegri moved this task from Kanban to Inbox on the cloud-services-team board.
KHernandez-WMF moved this task from Iteration 08 to Iteration 09 on the Toolforge Build Service board.Jan 24 2023, 6:08 PM
KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 09); removed Toolforge Build Service (Iteration 08).
KHernandez-WMF moved this task from Next Up to Blocked/Paused on the Toolforge Build Service (Iteration 09) board.
dcaro changed the task status from Stalled to In Progress.Jan 30 2023, 2:12 PM
dcaro moved this task from Blocked/Paused to In Progress on the Toolforge Build Service (Iteration 09) board.Feb 7 2023, 2:23 PM
KHernandez-WMF moved this task from Iteration 09 to Iteration 10 on the Toolforge Build Service board.Feb 7 2023, 4:39 PM
KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 10); removed Toolforge Build Service (Iteration 09).
KHernandez-WMF moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 10) board.
fnegri moved this task from Inbox to FY2022/2023-Q3 on the cloud-services-team board.Feb 10 2023, 11:59 AM
fnegri edited projects, added cloud-services-team (FY2022/2023-Q3); removed cloud-services-team.
KHernandez-WMF moved this task from Iteration 10 to Iteration 11 on the Toolforge Build Service board.Feb 21 2023, 8:45 PM
KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 11); removed Toolforge Build Service (Iteration 10).
KHernandez-WMF moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 11) board.
Raymond_Ndibe subscribed.Feb 23 2023, 11:04 PM

this has been merged and should be closed no @dcaro ?

dcaro added a comment.Feb 24 2023, 11:30 AM

It has not been deployed yet ;), I'll close on deployment

Raymond_Ndibe added a comment.Feb 24 2023, 6:46 PM

ok

gerritbot added a comment.Feb 28 2023, 10:15 AM

Change 892912 had a related patch set uploaded (by David Caro; author: David Caro):

[cloud/toolforge/toolforge-cli@main] build: add tag to builder image

https://gerrit.wikimedia.org/r/892912

gerritbot added a comment.Mar 7 2023, 10:49 AM

Change 892912 merged by jenkins-bot:

[cloud/toolforge/toolforge-cli@main] build: add tag to builder image

https://gerrit.wikimedia.org/r/892912

dcaro mentioned this in rCTTCf6eedcbad773: build: add tag to builder image.Mar 7 2023, 10:50 AM
dcaro moved this task from Iteration 11 to Focus Week! on the Toolforge Build Service board.Mar 9 2023, 1:32 PM
dcaro edited projects, added Toolforge Build Service (Focus Week!); removed Toolforge Build Service (Iteration 11).
dcaro moved this task from Next Up to In Progress on the Toolforge Build Service (Focus Week!) board.Mar 13 2023, 12:58 PM
dcaro closed this task as Resolved.Mar 13 2023, 3:41 PM
dcaro moved this task from In Progress to Done on the Toolforge Build Service (Focus Week!) board.
dcaro added a comment.Mar 13 2023, 3:50 PM

Note that the revision has to be the full commin sha if passing an sha

dcaro renamed this task from [tbs.cli] Add --revision parameter to allow specifying a branch/revision to [tbs.cli] Add --ref parameter to allow specifying a branch/revision.Mar 13 2023, 3:53 PM
dcaro updated the task description. (Show Details)
dcaro moved this task from Backlog to Done on the cloud-services-team (FY2022/2023-Q3) board.Apr 11 2023, 9:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL