Page MenuHomePhabricator
Create Task
Maniphest T325981

Replace and hard-deprecate Language::getLocalisationCache/getMessagesFor/getMessageFor/getMessageKeysFor (and remove in 1.41)
Closed, ResolvedPublic
Actions

Description

The functions

  • Language::getLocalisationCache
  • Language::getMessagesFor
  • Language::getMessageFor
  • Language::getMessageKeysFor

are deprecated. The usage should be replaced, the function hard-deprecated and removed

CodeSearch: https://codesearch.wmcloud.org/search/?q=%5CbLanguage%5Cs*%3A%3A%5Cs*(getLocalisationCache%7CgetMessagesFor%7CgetMessageFor%7CgetMessageKeysFor)%5Cb&i=nope&files=&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
Language: Remove deprecated functions and constantsmediawiki/coremaster+60 -679
Hard-deprecate Language::getLocalisationCache/getMessagesFormediawiki/coremaster+13 -6
Replace deprecated Language::getLocalisationCachemediawiki/extensions/LocalisationUpdatemaster+2 -2
Replace deprecated Language::getMessageFormediawiki/extensions/DonationInterfacemaster+1 -1
tests: Replace deprecated Language::getMessageFormediawiki/extensions/WikibaseQualityConstraintsmaster+3 -3
Customize query in gerrit

Event Timeline

Umherirrender created this task.Dec 28 2022, 3:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 28 2022, 3:46 PM
gerritbot added a comment.Dec 28 2022, 3:46 PM

Change 873009 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LocalisationUpdate@master] Replace deprecated Language::getLocalisationCache

https://gerrit.wikimedia.org/r/873009

gerritbot added a project: Patch-For-Review.Dec 28 2022, 3:46 PM
gerritbot added a comment.Dec 28 2022, 3:51 PM

Change 873011 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseQualityConstraints@master] tests: Replace deprecated Language::getMessageFor

https://gerrit.wikimedia.org/r/873011

gerritbot added a comment.Dec 28 2022, 3:53 PM

Change 873012 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DonationInterface@master] Replace deprecated Language::getMessageFor

https://gerrit.wikimedia.org/r/873012

Umherirrender moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.Dec 28 2022, 4:02 PM
gerritbot added a comment.Dec 29 2022, 5:48 PM

Change 873011 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] tests: Replace deprecated Language::getMessageFor

https://gerrit.wikimedia.org/r/873011

gerritbot added a comment.Dec 29 2022, 5:57 PM

Change 873012 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Replace deprecated Language::getMessageFor

https://gerrit.wikimedia.org/r/873012

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 29 2022, 6:01 PM
gerritbot added a comment.Jan 28 2023, 3:36 PM

Change 873009 merged by jenkins-bot:

[mediawiki/extensions/LocalisationUpdate@master] Replace deprecated Language::getLocalisationCache

https://gerrit.wikimedia.org/r/873009

Maintenance_bot removed a project: Patch-For-Review.Jan 28 2023, 4:30 PM
gerritbot added a comment.Feb 1 2023, 7:39 PM

Change 885869 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Hard-deprecate Language::getLocalisationCache/getMessagesFor

https://gerrit.wikimedia.org/r/885869

gerritbot added a project: Patch-For-Review.Feb 1 2023, 7:39 PM
gerritbot added a comment.Feb 22 2023, 10:01 PM

Change 885869 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate Language::getLocalisationCache/getMessagesFor

https://gerrit.wikimedia.org/r/885869

Maintenance_bot removed a project: Patch-For-Review.Feb 22 2023, 10:10 PM
Umherirrender renamed this task from Replace and hard-deprecate Language::getLocalisationCache/getMessagesFor/getMessageFor/getMessageKeysFor (and remove a release later) to Replace and hard-deprecate Language::getLocalisationCache/getMessagesFor/getMessageFor/getMessageKeysFor (and remove in 1.41).Feb 22 2023, 10:37 PM
Umherirrender changed the task status from Open to Stalled.
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.25; 2023-02-27); removed MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Feb 22 2023, 11:00 PM
Umherirrender changed the task status from Stalled to Open.Mar 14 2023, 9:34 PM
gerritbot added a comment.Aug 1 2023, 6:35 AM

Change 936685 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] Language: Remove deprecated functions and constants

https://gerrit.wikimedia.org/r/936685

gerritbot added a project: Patch-For-Review.Aug 1 2023, 6:35 AM
gerritbot added a comment.Aug 5 2023, 11:33 PM

Change 936685 merged by jenkins-bot:

[mediawiki/core@master] Language: Remove deprecated functions and constants

https://gerrit.wikimedia.org/r/936685

Maintenance_bot removed a project: Patch-For-Review.Aug 6 2023, 12:11 AM
Umherirrender closed this task as Resolved.Aug 7 2023, 11:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL