Page MenuHomePhabricator

Set 1 to = 1 for nfs names in PAWS
Closed, ResolvedPublic

Description

Currently clouddumps looks like this:

- name: dumps-src1
  hostPath:
    path: /mnt/nfs/dumps-clouddumps1002.wikimedia.org
    type: DirectoryOrCreate
- name: dumps-src2
  hostPath:
    path: /mnt/nfs/dumps-clouddumps1001.wikimedia.org
    type: DirectoryOrCreate

dumps-src2 = /mnt/nfs/dumps-clouddumps1001.wikimedia.org
And similar across the install. Make this such that
dumps-src1 = /mnt/nfs/dumps-clouddumps1001.wikimedia.org

Event Timeline

Hey @rook I want to contribute in this issue Can u guide me in which files I have to make changes ??

Hi! Yeah there are a few places, one of them is here:
https://github.com/toolforge/paws/blob/1b418695b7fc04050e4ab278642f2f26875eddef/paws/values.yaml#L96
Another is over here:
https://github.com/toolforge/paws/blob/1b418695b7fc04050e4ab278642f2f26875eddef/paws/values.yaml#L188

I think there are a few others, grep across the codebase for 100[12] and src[12] and see what you find.

Thanks!

@rook Hi I have doubt what should be change in this code.
Should it be
name: dumps-src1

hostPath:
  path: /mnt/nfs/dumps-clouddumps1001.wikimedia.org
  type: DirectoryOrCreate

name: dumps-src2

hostPath:
  path: /mnt/nfs/dumps-clouddumps1001.wikimedia.org
  type: DirectoryOrCreate

the values of 1002 change to 1001 or
just two lines
dumps-src1 = /mnt/nfs/dumps-clouddumps1001.wikimedia.org
dumps-src2 = /mnt/nfs/dumps-clouddumps1001.wikimedia.org
Can you explain it.

@Ayushk21 Hi! Oh I see, so what you want is any section with dumps-src1 you want it connected to clouddumps1001
At the same time we want any use of dumps-src2 to be connected to clouddumps1002
So in the second example we want it to look like:

- name: dumps-src2
  hostPath:
    path: /mnt/nfs/dumps-clouddumps1002.wikimedia.org
    type: DirectoryOrCreate

Please feel free to ask any further questions especially if I'm still not making sense :)

Thanks!

Hello @rook
I have made the change and pushed a pr .

That looks great! I'm going to get it deployed on Monday as we don't do much deploying on Friday and the weekend. Thank you for the pr!

rook changed the task status from Open to In Progress.Jan 27 2023, 2:48 PM
rook assigned this task to Ayushk21.