Page MenuHomePhabricator

Remove the .Values.kubernetesApi hack
Closed, ResolvedPublic

Description

We have a bunch of charts that use .Values.kubernetesApi to override the kubernetes api host and port in their local environment variables.

It should be possible to remove them those hacks completely with k8s 1.23 as the apiserver can be reached via the ClusterIP set in KUBERNETES_SERVICE_HOST, KUBERNETES_SERVICE_PORT_HTTPS and it's certificate can be validated for that IP as well.

I already did the most common ones, but the following charts still use it:

After all charts have been update, the chart module modules/base/kubernetes_1.0.0.tpl should be removed as well.

With all clusters migrated to 1.23, we should remove references from helmfile.d/admin_ng/

Event Timeline

Change 878751 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] cert-manager: Allow leader election to write configmaps

https://gerrit.wikimedia.org/r/878751

Change 878935 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] coredns: Remove deprecated nodeSelector, kubernetesApi hack

https://gerrit.wikimedia.org/r/878935

Change 878941 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] Remove kubernetesApi hack from helm-state-metrics and eventrouter

https://gerrit.wikimedia.org/r/878941

Change 878943 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] calico: Remove kubernetesApi hack

https://gerrit.wikimedia.org/r/878943

Change 878946 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] staging-codfw: Remove kubernetesApi hack

https://gerrit.wikimedia.org/r/878946

Change 878751 merged by jenkins-bot:

[operations/deployment-charts@master] cert-manager: Allow leader election to write configmaps

https://gerrit.wikimedia.org/r/878751

Change 878935 merged by jenkins-bot:

[operations/deployment-charts@master] coredns: Remove deprecated nodeSelector, kubernetesApi hack

https://gerrit.wikimedia.org/r/878935

Change 878941 merged by jenkins-bot:

[operations/deployment-charts@master] Remove kubernetesApi hack from helm-state-metrics and eventrouter

https://gerrit.wikimedia.org/r/878941

Change 878943 merged by jenkins-bot:

[operations/deployment-charts@master] calico: Remove kubernetesApi hack

https://gerrit.wikimedia.org/r/878943

Change 878946 merged by jenkins-bot:

[operations/deployment-charts@master] staging-codfw: Remove kubernetesApi hack

https://gerrit.wikimedia.org/r/878946

Change 889780 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] wikikube istio: Remote the .Values.kubernetesApi hack

https://gerrit.wikimedia.org/r/889780

Change 889780 merged by jenkins-bot:

[operations/deployment-charts@master] wikikube istio: Remote the .Values.kubernetesApi hack

https://gerrit.wikimedia.org/r/889780

Change 895336 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] Remove the .Values.kubernetesApi hack

https://gerrit.wikimedia.org/r/895336

Change 895336 merged by jenkins-bot:

[operations/deployment-charts@master] Remove the .Values.kubernetesApi hack

https://gerrit.wikimedia.org/r/895336

Change 895704 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] flink-session-cluster: Bump chart version

https://gerrit.wikimedia.org/r/895704

Change 895704 merged by jenkins-bot:

[operations/deployment-charts@master] flink-session-cluster: Bump chart version

https://gerrit.wikimedia.org/r/895704

Change 895765 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] Revert: Remove the .Values.kubernetesApi hack

https://gerrit.wikimedia.org/r/895765

Change 895765 merged by jenkins-bot:

[operations/deployment-charts@master] Revert: Remove the .Values.kubernetesApi hack

https://gerrit.wikimedia.org/r/895765

flink-session-cluster still carries the hack (see description). As that isn't a problem (it will still work) and the chart will go away, I'm going to resolve this.

Change 935002 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] Remove kubernetesApi hack from rdf-streaming-updater

https://gerrit.wikimedia.org/r/935002

Change 935003 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/puppet@production] deployment_server/kubernetes: Remove kubernetesApi hack

https://gerrit.wikimedia.org/r/935003

Change 935003 merged by JMeybohm:

[operations/puppet@production] deployment_server/kubernetes: Remove kubernetesApi hack

https://gerrit.wikimedia.org/r/935003

Change 935002 merged by jenkins-bot:

[operations/deployment-charts@master] Remove kubernetesApi hack from rdf-streaming-updater

https://gerrit.wikimedia.org/r/935002