We have a bunch of charts that use .Values.kubernetesApi to override the kubernetes api host and port in their local environment variables.
It should be possible to remove them those hacks completely with k8s 1.23 as the apiserver can be reached via the ClusterIP set in KUBERNETES_SERVICE_HOST, KUBERNETES_SERVICE_PORT_HTTPS and it's certificate can be validated for that IP as well.
I already did the most common ones, but the following charts still use it:
- charts/flink-session-cluster: I had to revert the change here as is lead to a super strange helm diff effectively making it impossible to upgrade, see: https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/895765. The chart is going to go away sooner than later (T326409: Migrate the wdqs streaming updater flink jobs to flink-k8s-operator deployment model) so I did not investigate in detail.
- charts/knative-serving
- charts/kserve
After all charts have been update, the chart module modules/base/kubernetes_1.0.0.tpl should be removed as well.
With all clusters migrated to 1.23, we should remove references from helmfile.d/admin_ng/