less.php ParseError with variable interpolation after ':' in selector
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Jan 17 2023, 11:38 AM

Description

Imported from https://github.com/wikimedia/less.php/issues/52.

@plumbojumbo@github.com wrote on 30 Nov 2020:
This succeeds:
(new Less_Parser())->parse('@position: after; .@{position} {}');
This, however, fails:
(new Less_Parser())->parse('@position: after; &:@{position} {}');
ParseError: Unexpected input in anonymous-file-2.less on line 1, column 14
1| @foo: after; &:@{foo} {}
Both Less.js and lessphp compile it just fine. (cmp.)

Details

	Subject	Repo	Branch	Lines +/-
	Fix ParseError when interpolating variable after colon in selector	mediawiki/libs/less.php	master	+18 -1
	Less_Parser: Misc clean up for readability and parity with less.js	mediawiki/libs/less.php	master	+70 -37

Customize query in gerrit

Event Timeline

Krinkle created this task.Jan 17 2023, 11:38 AM

Restricted Application added a project: Performance-Team. · View Herald TranscriptJan 17 2023, 11:38 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I have confirmed that this passes on the specific Less.js version we aim to support (Less.js 2.5.3), e.g. via fiddle.

@position: after;

.foo {
    &:@{position} {
        color: green;
    }
}

Which Less.js 2.5.3 compiles to:

.foo:after {
  color: green;
}

Krinkle triaged this task as Medium priority.Jan 17 2023, 11:46 AM

Change 880942 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/libs/less.php@master] Less_Marser: Misc clean up for readability and parity with less.js

https://gerrit.wikimedia.org/r/880942

Change 880943 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/libs/less.php@master] Fix ParseError when interpolating variable after colon in selector

https://gerrit.wikimedia.org/r/880943

Krinkle claimed this task.Jan 17 2023, 12:05 PM

Krinkle moved this task from Inbox, needs triage to Doing: Prio Interrupt on the Performance-Team board.

Change 880942 merged by jenkins-bot:

[mediawiki/libs/less.php@master] Less_Parser: Misc clean up for readability and parity with less.js

https://gerrit.wikimedia.org/r/880942

Change 880943 merged by jenkins-bot:

[mediawiki/libs/less.php@master] Fix ParseError when interpolating variable after colon in selector

https://gerrit.wikimedia.org/r/880943

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2023, 3:31 PM

Krinkle closed this task as Resolved.Feb 9 2023, 5:08 PM

less.php ParseError with variable interpolation after ':' in selector Closed, ResolvedPublicActions

Description

Details

Event Timeline

less.php ParseError with variable interpolation after ':' in selector
Closed, ResolvedPublic
Actions