Page MenuHomePhabricator

Language fallback indicators still shown for variant fallbacks on mobile Wikidata
Closed, ResolvedPublic

Description

As a mobile Wikidata visitor, I don’t want to see language fallback indicators if the fallback is just within language variants, e. g. from British or Canadian English (en-gb, en-ca) to “English” (en).

Problem:
Language fallback indicators for variant fallbacks are hidden on desktop (implemented in T174318 and since then fixed in a few more places), but not on mobile. The relevant styles are currently in the desktop-only wikibase.common ResourceLoader module.

Tech note: T325084 splits wikibase.common into two modules; the styles that hide variant fallback indicators should then move from wikibase.desktop to wikibase.alltargets. This also means that a bunch of places can stop loading the more heavyweight wikibase.desktop module – history views, Special:NewLexeme etc. only need the link styles from wikibase.alltargets.

Example:
This en-ca mobile item view or this en-ca mobile diff shows the indicators for the fallback from Canadian English to English:

image.png (234×993 px, 32 KB)

image.png (149×331 px, 10 KB)

Screenshots/mockups:

BDD
GIVEN I am looking at the mobile version of the site
AND my user interface language is a “variant” language
WHEN looking at item links where the label fell back to the “base” language
THEN there is no visible fallback indicator

Acceptance criteria:

  • Language fallback indicators for variant fallbacks aren’t shown on mobile.
  • Language fallback indicators for non-variant fallbacks are still shown everywhere, of course.

Open questions:

Event Timeline

Another part of wikibase.common that gets lost on mobile is that the entity ID part of an entity link (“Douglas Adams (Q42)”) is shown in a slightly smaller font. I don’t think this is worth a separate Phabricator task, it’s just another bit of CSS that should be moved to the “all targets” module at the same time.

Change 884355 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Move itemlink styles to wikibase.alltargets

https://gerrit.wikimedia.org/r/884355

Change 884356 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Don’t require wikibase.desktop module

https://gerrit.wikimedia.org/r/884356

Not related to mobile but T291817 is another place where the indicators are still being shown

Change 884355 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move itemlink styles to wikibase.alltargets

https://gerrit.wikimedia.org/r/884355

Change 884356 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Don’t require wikibase.desktop module

https://gerrit.wikimedia.org/r/884356

Lucas_Werkmeister_WMDE claimed this task.

As far as I can tell, this has been fixed with the above Gerrit changes.