Hooks.php should be split into separate HookHandler files. This makes it easier to read and update the files, including the associated tests.
Currently the Hooks.php file contains 1200 lines and HooksTest.php contains 1400 lines. These could be split into multiple Hook Handler files, including:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T328334 Split Hooks.php into seperate HookHandler files | |||
| Open | Dreamy_Jazz | T359560 Create the CheckUserDataPruner service |
Change 928481 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Move ::onLoadExtensionSchemaUpdates to hook handler file
Change 928493 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Move toollinks related hooks to a hook handler file
Change 928481 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Move ::onLoadExtensionSchemaUpdates to hook handler file
Change 928527 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Move Hooks::onRenameUserSQL to hook handler file and unit test
Change 928493 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Move toollinks related hooks to a hook handler file
Change 928527 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Move Hooks::onRenameUserSQL to hook handler file and unit test
Change 928553 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Move Hooks::onSpecialPage_initList to a hook handler file
Change 928553 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Move Hooks::onSpecialPage_initList to a hook handler file
Change 928893 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Move CheckUser services in the root folder to a new sub-folder
Change 928962 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Move Hooks::insertIntoCu* methods and Hooks::getAgent to a service
Change 929030 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Move Hooks::maybePruneIPData and ::pruneIPData to a new service
Change 929031 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Move all code in Hooks.php that inserts data to CU to new handler
Change 929032 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Remove unused private methods in Hooks.php
Change 928893 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Move CheckUser services in the root folder to a new sub-folder
Change 929032 abandoned by Dreamy Jazz:
[mediawiki/extensions/CheckUser@master] Remove unused private methods in Hooks.php
Reason:
Will re-create this as another patch. Some usages still exist in tests which will need to be removed before a patch like this can be used.
Change 928962 abandoned by Dreamy Jazz:
[mediawiki/extensions/CheckUser@master] Move many non-hook methods in Hooks.php to a service
Reason:
Intending to split this into multiple changes at a future time
Change 929031 abandoned by Dreamy Jazz:
[mediawiki/extensions/CheckUser@master] Move all code in Hooks.php that inserts data to CU to new handler
Reason:
Intend to split this into multiple smaller patches at a later time.
Change 928962 restored by Dreamy Jazz:
[mediawiki/extensions/CheckUser@master] Move many non-hook methods in Hooks.php to a service
Change 928962 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Move multiple Hooks.php methods to CheckUserInsert service
Change #1046774 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Add read new support to CheckUser autoblocking handling code
Change #1046774 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Add read new support to CheckUser autoblocking handling code