Page MenuHomePhabricator
Create Task
Maniphest T328334

Split Hooks.php into seperate HookHandler files
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Hooks.php should be split into separate HookHandler files. This makes it easier to read and update the files, including the associated tests.

Currently the Hooks.php file contains 1200 lines and HooksTest.php contains 1400 lines. These could be split into multiple Hook Handler files, including:

  • One for schema updates which are hard to test and often updated
  • One for ones that insert events into the checkuser tables, which can be grouped together to still keep the insertion methods private.

Details

SubjectRepoBranchLines +/-
Move Hooks::updateCheckUserData to CheckUserInsert servicemediawiki/extensions/CheckUsermaster+291 -407
Remove wgCheckUserEventTablesMigrationStage for user created handlermediawiki/extensions/CheckUsermaster+56 -117
Move RecentChanges save handler to separate filemediawiki/extensions/CheckUsermaster+207 -126
Remove wgCheckUserEventTablesMigrationStage for reset email handlermediawiki/extensions/CheckUsermaster+58 -100
Remove wgCheckUserEventTablesMigrationStage for email handlermediawiki/extensions/CheckUsermaster+229 -221
Remove wgCheckUserEventTablesMigrationStage for login handlermediawiki/extensions/CheckUsermaster+290 -411
Remove wgCheckUserEventTablesMigrationStage for logout handlermediawiki/extensions/CheckUsermaster+176 -137
Add read new support to CheckUser autoblocking handling codemediawiki/extensions/CheckUsermaster+261 -152
Move multiple Hooks.php methods to CheckUserInsert servicemediawiki/extensions/CheckUsermaster+676 -609
Move all code in Hooks.php that inserts data to CU to new handlermediawiki/extensions/CheckUsermaster+953 -859
Remove unused private methods in Hooks.phpmediawiki/extensions/CheckUsermaster+0 -91
Move CheckUser services in the root folder to a new sub-foldermediawiki/extensions/CheckUsermaster+70 -63
Move Hooks::onSpecialPage_initList to a hook handler filemediawiki/extensions/CheckUsermaster+130 -116
Move Hooks::onRenameUserSQL to hook handler file and unit testmediawiki/extensions/CheckUsermaster+50 -13
Move toollinks related hooks to a hook handler filemediawiki/extensions/CheckUsermaster+199 -145
Move ::onLoadExtensionSchemaUpdates to hook handler filemediawiki/extensions/CheckUsermaster+289 -281
Show related patches Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Jan 30 2023, 4:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2023, 4:44 PM
Dreamy_Jazz triaged this task as Low priority.Jan 30 2023, 4:46 PM
Dreamy_Jazz added a project: Core Platform Team Initiatives (New Hook System).
Dreamy_Jazz added a parent task: T312668: Update CheckUser to use the new HookContainer/HookRunner system.
gerritbot added a comment.Jun 8 2023, 10:32 AM

Change 928481 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Move ::onLoadExtensionSchemaUpdates to hook handler file

https://gerrit.wikimedia.org/r/928481

gerritbot added a project: Patch-For-Review.Jun 8 2023, 10:32 AM
gerritbot added a comment.Jun 8 2023, 11:10 AM

Change 928493 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Move toollinks related hooks to a hook handler file

https://gerrit.wikimedia.org/r/928493

gerritbot added a comment.Jun 8 2023, 11:23 AM

Change 928481 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Move ::onLoadExtensionSchemaUpdates to hook handler file

https://gerrit.wikimedia.org/r/928481

gerritbot added a comment.Jun 8 2023, 12:35 PM

Change 928527 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Move Hooks::onRenameUserSQL to hook handler file and unit test

https://gerrit.wikimedia.org/r/928527

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 8 2023, 1:00 PM
gerritbot added a comment.Jun 8 2023, 1:02 PM

Change 928493 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Move toollinks related hooks to a hook handler file

https://gerrit.wikimedia.org/r/928493

gerritbot added a comment.Jun 8 2023, 1:43 PM

Change 928527 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Move Hooks::onRenameUserSQL to hook handler file and unit test

https://gerrit.wikimedia.org/r/928527

gerritbot added a comment.Jun 8 2023, 1:58 PM

Change 928553 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Move Hooks::onSpecialPage_initList to a hook handler file

https://gerrit.wikimedia.org/r/928553

gerritbot added a comment.Jun 9 2023, 11:20 AM

Change 928553 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Move Hooks::onSpecialPage_initList to a hook handler file

https://gerrit.wikimedia.org/r/928553

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2023, 11:29 AM
gerritbot added a comment.Jun 9 2023, 6:47 PM

Change 928893 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Move CheckUser services in the root folder to a new sub-folder

https://gerrit.wikimedia.org/r/928893

gerritbot added a project: Patch-For-Review.Jun 9 2023, 6:47 PM
gerritbot added a comment.Jun 9 2023, 11:14 PM

Change 928962 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Move Hooks::insertIntoCu* methods and Hooks::getAgent to a service

https://gerrit.wikimedia.org/r/928962

gerritbot added a comment.Jun 11 2023, 10:24 PM

Change 929030 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Move Hooks::maybePruneIPData and ::pruneIPData to a new service

https://gerrit.wikimedia.org/r/929030

gerritbot added a comment.Jun 11 2023, 11:56 PM

Change 929031 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Move all code in Hooks.php that inserts data to CU to new handler

https://gerrit.wikimedia.org/r/929031

gerritbot added a comment.Jun 12 2023, 12:00 AM

Change 929032 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove unused private methods in Hooks.php

https://gerrit.wikimedia.org/r/929032

gerritbot added a comment.Jun 20 2023, 12:41 PM

Change 928893 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Move CheckUser services in the root folder to a new sub-folder

https://gerrit.wikimedia.org/r/928893

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.15; 2023-06-27); removed MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 20 2023, 1:00 PM
gerritbot added a comment.Jun 20 2023, 2:54 PM

Change 929032 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] Remove unused private methods in Hooks.php

Reason:

Will re-create this as another patch. Some usages still exist in tests which will need to be removed before a patch like this can be used.

https://gerrit.wikimedia.org/r/929032

Dreamy_Jazz removed a parent task: T312668: Update CheckUser to use the new HookContainer/HookRunner system.Sep 17 2023, 8:44 PM
gerritbot added a comment.Jan 7 2024, 10:55 AM

Change 928962 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] Move many non-hook methods in Hooks.php to a service

Reason:

Intending to split this into multiple changes at a future time

https://gerrit.wikimedia.org/r/928962

gerritbot added a comment.Jan 7 2024, 10:56 AM

Change 929031 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] Move all code in Hooks.php that inserts data to CU to new handler

Reason:

Intend to split this into multiple smaller patches at a later time.

https://gerrit.wikimedia.org/r/929031

gerritbot added a comment.Feb 8 2024, 1:27 PM

Change 928962 restored by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] Move many non-hook methods in Hooks.php to a service

https://gerrit.wikimedia.org/r/928962

gerritbot added a comment.Feb 23 2024, 8:47 PM

Change 928962 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Move multiple Hooks.php methods to CheckUserInsert service

https://gerrit.wikimedia.org/r/928962

gerritbot added a comment.Jun 18 2024, 1:06 PM

Change #1046774 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add read new support to CheckUser autoblocking handling code

https://gerrit.wikimedia.org/r/1046774

gerritbot added a comment.Jun 21 2024, 1:16 PM

Change #1046774 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add read new support to CheckUser autoblocking handling code

https://gerrit.wikimedia.org/r/1046774

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jun 21 2024, 2:00 PM
gerritbot added a comment.Jul 8 2024, 12:36 PM

Change #1052729 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for logout handler

https://gerrit.wikimedia.org/r/1052729

gerritbot added a comment.Jul 8 2024, 1:11 PM

Change #1052735 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for login handler

https://gerrit.wikimedia.org/r/1052735

gerritbot added a comment.Jul 8 2024, 1:42 PM

Change #1052744 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for email handler

https://gerrit.wikimedia.org/r/1052744

gerritbot added a comment.Jul 8 2024, 1:58 PM

Change #1052747 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for reset email handler

https://gerrit.wikimedia.org/r/1052747

gerritbot added a comment.Jul 8 2024, 2:38 PM

Change #1052758 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for user created handler

https://gerrit.wikimedia.org/r/1052758

gerritbot added a comment.Jul 8 2024, 5:10 PM

Change #1052787 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Remove wgCheckUserEventTablesMigrationStage for recentchange save

https://gerrit.wikimedia.org/r/1052787

gerritbot added a comment.Jul 8 2024, 5:18 PM

Change #1052788 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Move Hooks::updateCheckUserData to CheckUserInsert service

https://gerrit.wikimedia.org/r/1052788

Dreamy_Jazz claimed this task.Jul 9 2024, 11:53 AM
Dreamy_Jazz set the point value for this task to 2.
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)).
Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.
gerritbot added a comment.Jul 10 2024, 6:06 PM

Change #1052729 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for logout handler

https://gerrit.wikimedia.org/r/1052729

gerritbot added a comment.Jul 10 2024, 6:33 PM

Change #1052735 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for login handler

https://gerrit.wikimedia.org/r/1052735

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.14; 2024-07-16); removed MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jul 10 2024, 7:00 PM
gerritbot added a comment.Jul 11 2024, 2:40 PM

Change #1052744 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for email handler

https://gerrit.wikimedia.org/r/1052744

gerritbot added a comment.Jul 11 2024, 2:57 PM

Change #1052747 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for reset email handler

https://gerrit.wikimedia.org/r/1052747

gerritbot added a comment.Jul 11 2024, 4:42 PM

Change #1052758 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for user created handler

https://gerrit.wikimedia.org/r/1052758

gerritbot added a comment.Jul 11 2024, 4:51 PM

Change #1052788 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Move Hooks::updateCheckUserData to CheckUserInsert service

https://gerrit.wikimedia.org/r/1052788

gerritbot added a comment.Jul 11 2024, 4:51 PM

Change #1052787 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Move RecentChanges save handler to separate file

https://gerrit.wikimedia.org/r/1052787

Dreamy_Jazz closed this task as Resolved.Jul 11 2024, 7:37 PM
Dreamy_Jazz moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.
Dreamy_Jazz removed a subtask: T359560: Create the CheckUserDataPruner service.Aug 20 2024, 9:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits