Switch to MediaWiki coding style
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Samwilson
	Feb 3 2023, 5:47 AM

Description

In PR 63 the snake_case variable names were not picked up by phpcs. I was going to suggest we add a phpcs check for this, but it might be better to just switch to using the standard MediaWiki coding rules (like we do on most PHP codebases).

Event Timeline

Samwilson created this task.Feb 3 2023, 5:47 AM

Restricted Application added a project: Community-Tech. · View Herald TranscriptFeb 3 2023, 5:47 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

TheresNoTime updated the task description. (Show Details)Feb 13 2023, 3:21 PM

• JMcLeod_WMF moved this task from New & TBD Tickets to Engineering Backlog on the Community-Tech board.Feb 13 2023, 3:21 PM

• JMcLeod_WMF removed a project: Community-Tech.Feb 28 2023, 12:22 AM

I've modified the existing code to use the Mediawiki coding rules, but it is probably better if we merge the pending PRs and then work on refactoring the code as this will reduce conflicts.

Samwilson moved this task from Backlog to Transkribus on the Wikimedia OCR board.Mar 13 2023, 7:39 AM

Github Pull Request (for changing the phpcs rules and automatic linting fixes based on the MediaWiki coding rules) can be found here

First part of this is merged, thanks!

The exclusions can now be sorted out.

The second part of this task can be found on this PR (removing exclusions and fixing linting errors/warnings)

• PMenon-WMF closed this task as Resolved.May 16 2023, 9:05 AM

Switch to MediaWiki coding styleClosed, ResolvedPublicActions

Description

Event Timeline

Switch to MediaWiki coding style
Closed, ResolvedPublic
Actions