Do not set callback_is_prefix for OAuth 2.0 clients in the API Portal
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	apaskulin
	Feb 6 2023, 8:09 PM

Description

Current behavior

The API Portal sets callback_is_prefix to true for OAuth 2.0 clients by default.

Expected behavior

callback_is_prefix doesn't apply to OAuth 2.0 clients (See T264516), so it should be set to false by default in the API Portal, which only supports OAuth 2.0.

Details

	Subject	Repo	Branch	Lines +/-
	widget: Fix default behavior for callback prefix	mediawiki/extensions/WikimediaApiPortalOAuth	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rEWAP637b32ce5ce1: widget: Fix default behavior for callback prefix
Mentioned Here: T264516: Documentation does not mention that OAuth2 does NOT support "use as prefix" option for callback URL

Event Timeline

apaskulin created this task.Feb 6 2023, 8:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2023, 8:09 PM

Change 886848 had a related patch set uploaded (by Alex Paskulin; author: Alex Paskulin):

[mediawiki/extensions/WikimediaApiPortalOAuth@master] widget: Fix default behavior for callback prefix

https://gerrit.wikimedia.org/r/886848

gerritbot added a project: Patch-For-Review.Feb 6 2023, 8:24 PM

bd808 awarded a token.Feb 6 2023, 10:58 PM

Change 886848 merged by jenkins-bot:

[mediawiki/extensions/WikimediaApiPortalOAuth@master] widget: Fix default behavior for callback prefix

https://gerrit.wikimedia.org/r/886848

apaskulin mentioned this in rEWAP637b32ce5ce1: widget: Fix default behavior for callback prefix.Feb 10 2023, 5:38 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 10 2023, 6:00 PM

apaskulin moved this task from Backlog to Tech debt on the API-Portal board.Feb 10 2023, 6:03 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 10 2023, 6:30 PM

Verified on Beta

Do not set callback_is_prefix for OAuth 2.0 clients in the API PortalClosed, ResolvedPublicActions