Page MenuHomePhabricator

Upgrade Gerrit from 3.5.4 to 3.5.5
Closed, ResolvedPublic

Description

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Gerrit version 3.5.5 is now available.

Release Notes:
https://www.gerritcodereview.com/3.5.html#355

Documentation:
http://gerrit-documentation.storage.googleapis.com/Documentation/3.5.5/index.html

Log of changes since 3.5.3:
https://gerrit.googlesource.com/gerrit/+log/v3.5.3..v3.5.5?no-merges

Download:
https://gerrit-releases.storage.googleapis.com/gerrit-3.5.5.war

SHA1:
a7c06f5243a7a27ddc35c1c3fc775efdb138e665

SHA256:
12697ea718a2f018bac36ac83941927b2151fc560994905b053ff804d4b6ba9c

MD5:
d782008149cc73414ecff11d8d00af04

Maintainers' public keys:
https://www.gerritcodereview.com/releases/public-keys.md

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEmCU49QQ43XtIE8giC0731aK2mH4FAmP7bAcACgkQC0731aK2
mH5r7Q/6ArM7bbQePbpa/2SvudZRR9tgOcA0OtpFnyNliZUo3c4Y0MuGMGRI0EB1
xZ6B7LMRr0waK/yICAsVeJ39aGE4EHPS0XYU9RwyyrhAN1Lr7SYVXedUisL+NvlT
LflGVKcQBhgPwJMbFjrbOHY8dYBAruAcQWhy0yrGVpwQpJjo4keYhpnemJSJ41tk
CuM4JgQBQA7Zf5x2JKZEKqheUt1kPmmld0jPFa9O5ros0pJAg06X/+fUnkNnzvQA
B+Ptmgzx/m41pZI5a9uwzjk7nPtb8tFNl41/6zwYLAyzTpB7F2xBrRNu014KPNWT
yJJcvz7CzCZYOHHTikDBZVPz7bTozDN3/d4pcNt+q1CubQV1zvjOlrKTNDM41bt2
Jh9yrSBpnA3XMM1U4j32I8ylAP9XTOFu3tWT9xhJ8Do89efV5TS9p2dukwzplM1Q
LxaUdTt1WJLDJ64g05U6wJaS9U3MGg6l+KSe9mQ1F9Pr95zNacU1RsgLwRvcFjir
tLNQ1Sv48uT1svyv9tVTWKq18IVvIhZu2Ln40WR4YLDojm0U6HdRJFQal9pznEzE
iyxE/4JUiezX1ju4T7o7M1UJ8XR8Lrlzs/Wjx8oHXSosxH0v0dnEkOfTvgK52AQE
ugs21GqoDdNpJKg1ugs9mYCdUCLjcd21ekb/x6zcTRbQUjV4ZOI=

sKCB

-----END PGP SIGNATURE-----


Abstract from the changelog:

Change 353177: Add tsconfig-plugins-base.json to Gerrit TypeScript Plugin API.

Adds tsconfig-plugins-base.json to the npm package so downstream plugins can easily use the same set of TypeScript settings.

A patch I have made which hopefully got released to npmjs.org as new versions. That is for our JavaScript plugins.

Change 353594: Inserting new patch-sets is retried on lock failures.

Mitigates failures when creating new patch-sets fails if the notedb ref is locked for another update on the change.

I am pretty sure we had (still have?) tasks filed about this when sending patches too quickly or some variation of it.

Event Timeline

There are also some updates to sshd (new version is 2.9.2) which might address some issues due to newer keys or old algo being disabled on some distro.

Change 893723 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@wmf/stable-3.5] Merge tag 'v3.5.5' into wmf/stable-3.5

https://gerrit.wikimedia.org/r/893723

Change 893723 merged by jenkins-bot:

[operations/software/gerrit@wmf/stable-3.5] Merge tag 'v3.5.5' into wmf/stable-3.5

https://gerrit.wikimedia.org/r/893723

Change 893743 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@deploy/wmf/stable-3.5] Update Gerrit to v3.5.5 and rebuild plugins

https://gerrit.wikimedia.org/r/893743

I have scheduled it for Monday March 6th at 9:00 UTC which is after the UTC morning backport window.

gerrit3.5.5_deployment_window.png (131×638 px, 25 KB)

I have announced it on wikitech-l.

hashar set Due Date to Mar 6 2023, 8:00 AM.Mar 2 2023, 4:46 PM

Change 893743 merged by jenkins-bot:

[operations/software/gerrit@deploy/wmf/stable-3.5] Update Gerrit to v3.5.5 and rebuild plugins

https://gerrit.wikimedia.org/r/893743

I have upgraded both Gerrit instances and confirmed they have the whole set of plugins enabled (and at 3.5.5).

Running Puppet I have noticed:

Notice: /Stage[main]/Gerrit/File[/var/lib/gerrit2/review_site/etc/replication.config]/mode: mode changed '0644' to '0444' (corrective)
Notice: /Stage[main]/Gerrit/Systemd::Service[gerrit]/Service[gerrit]/ensure: ensure changed 'stopped' to 'running' (corrective)

That is gerrit init altering the files permissions, it is essentially harmless.