Tests: Ensure that RequireLoginMixin is in mro prior than NeedRightsMixin
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Xqt
	Mar 6 2023, 8:44 AM

Description

What happens?:
For example NeedRightsMixin can be used to ensure that needed rights are given during tests but the needed rigths can depend on the fqact that a user is logged in. Unfortunately the RequireLoginMixin is placed later in the mro so that the rights does not reflect the right situation after login is made. Currently NeedRightsMixin is mostly senseless.

Software version
Pywikibot 7.7.1: rPWBCd87931a

Details

	Subject	Repo	Branch	Lines +/-
	[tests] Ensure that login is made prior than rights are checked	pywikibot/core	master	+6 -3

Customize query in gerrit

Related Objects

Mentioned Here: rPWBCd87931a2e624: [tests] Add ability to require special rights for tests

Event Timeline

Xqt created this task.Mar 6 2023, 8:44 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptMar 6 2023, 8:44 AM

Xqt triaged this task as Medium priority.Mar 6 2023, 8:46 AM

Xqt updated the task description. (Show Details)

binbot subscribed.Mar 6 2023, 9:04 AM

Xqt claimed this task.Mar 6 2023, 9:33 AM

Change 894530 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] Ensure that login is made prior than rights are checked

https://gerrit.wikimedia.org/r/894530

gerritbot added a project: Patch-For-Review.Mar 6 2023, 9:36 AM

@Xqt, I was asked to review, but I cannot run tests properly because of the submodule update problem, and I don't know a test case for this, just subscribed to follow.

Change 894530 merged by jenkins-bot: