Page MenuHomePhabricator

builds that are still running should not be reported as "ok"
Closed, ResolvedPublic

Description

the "status" column of toolforge build list currently has three possible values, "ok", "error" and "cancelled". The implication of this is that builds that are still running are also reported as "ok" but this can be confusing for a user.
Imagine running a build (that will eventually fail) and the status is reported as "ok" along side builds that has completed and are successful.
A typical user will go ahead to try and make use of the build image because the status was "ok".

We should have a fourth value like "running" or "pending"

Event Timeline

Screenshot of both list with the confusing value, and show with a less confusing one (thanks @taavi!):

image.png (371×2 px, 71 KB)

Raymond_Ndibe changed the task status from Open to In Progress.May 4 2023, 11:40 PM
Raymond_Ndibe claimed this task.

Change 916557 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[cloud/toolforge/toolforge-cli@main] toolforge-cli: improve build_show and build_list outputs

https://gerrit.wikimedia.org/r/916557

Raymond_Ndibe changed the task status from In Progress to Stalled.May 5 2023, 6:42 PM
dcaro changed the task status from Stalled to In Progress.May 9 2023, 1:30 PM

Change 916557 merged by jenkins-bot:

[cloud/toolforge/toolforge-cli@main] toolforge-cli: improve build_show and build_list outputs

https://gerrit.wikimedia.org/r/916557