Page MenuHomePhabricator
Create Task
Maniphest T332467

Implement GRAMMAR magic word for Serbo-Croatian localization
Closed, ResolvedPublic
Actions

Description

Аlready supported in Bosnian, it will be useful to have it for Serbo-Croatian interface localization.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix warning that $grammarForms['sh'] is undefinedmediawiki/coremaster+5 -0
Add support for GRAMMAR in Serbo-Croatianmediawiki/coremaster+62 -0
Add GRAMMAR table for Serbo-Croatianmediawiki/extensions/WikimediaMessagesmaster+80 -0
Customize query in gerrit

Related Objects

Event Timeline

Aca created this task.Mar 18 2023, 8:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2023, 8:32 AM
Aca moved this task from Untriaged to Grammar on the I18n board.Mar 18 2023, 8:33 AM
Vipz awarded a token.Mar 19 2023, 9:20 AM
Msz2001 removed Aca as the assignee of this task.Jan 21 2025, 2:05 PM
Msz2001 subscribed.

Hi, @Aca!

I can help with adding these. But, as I don't speak this language, could you please provide me a table of words and their grammar forms that you'd like to have implemented?

Like for example these (of course, you can just send a list, not neccessarily a ready PHP excerpt): https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikimediaMessages/+/4fdf83e0917d097760f2d7edfb093de6a0c16abd/includes/Hooks.php#1380

Grammar support in MediaWiki works based on a dictionary lookup, so it can support a limited pre-defined set of words and cases. The grammar case symbols can be anything (e.g., a shortcut or a full name or anything that would be understandable and useful).

For example (of course, instead of case1 etc. some more descriptive name to be used right after the colon in {{GENDER:):

base wordcase1case2
WikipedijaWikipedijiWikipediju
Aca added a comment.Jan 22 2025, 7:12 PM

Hi, @Msz2001 ! Thanks for your engagement! We're currently having an on-wiki discussion about standardizing names for several Wikimedia projects. I'll reach you out with my input following the discussion.

jhsoby subscribed.Jan 23 2025, 6:43 PM
In T332467#10479641, @Msz2001 wrote:

Grammar support in MediaWiki works based on a dictionary lookup, so it can support a limited pre-defined set of words and cases. […]

Some grammar functions work like that, but not all. The limiting factor is the complexity of the language's rules. Two examples:

  • LanguageFi.php: Several cases, but made to support sitenames only because the language's rules are complex
  • grammarTransformations/nb.json: One case, but supports basically everything, because the rules for this are easy and straightforward
Msz2001 added a comment.Jan 23 2025, 6:46 PM
In T332467#10490146, @jhsoby wrote:
In T332467#10479641, @Msz2001 wrote:

Grammar support in MediaWiki works based on a dictionary lookup, so it can support a limited pre-defined set of words and cases. […]

Some grammar functions work like that, but not all. The limiting factor is the complexity of the language's rules. Two examples:

  • LanguageFi.php: Several cases, but made to support sitenames only because the language's rules are complex
  • grammarTransformations/nb.json: One case, but supports basically everything, because the rules for this are easy and straightforward

Ah, fair point! Since this task is about a Slavic language, I've automatically assumed it's non-trivial to implement in general :D (but that's true, I wasn't clear about that)

Aca added a comment.Jan 30 2025, 2:46 AM

@Msz2001 Hi, here is a table of words with their grammar forms.

Serbo-Croatian Latin (sh-Latn):
(sorted by the English word for consistency, English terms bolded, italics = no changes)

Englishbase wordgenitivdativakuzativvokativinstrumentallokativ
WikibooksWikiknjigeWikiknjigaWikiknjigamaWikiknjigeWikiknjigeWikiknjigamaWikiknjigama
WikidataWikipodaciWikipodatakaWikipodacimaWikipodatkeWikipodaciWikipodacimaWikipodacima
WikifunctionsWikifunkcijeWikifunkcijaWikifunkcijamaWikifunkcijeWikifunkcijeWikifunkcijamaWikifunkcijama
Wikimedia CommonsWikimedijina ostavaWikimedijine ostaveWikimedijinoj ostaviWikimedijinu ostavuWikimedijina ostavoWikimedijinom ostavomWikimedijinoj ostavi
WikinewsWikinovostiWikinovostiWikinovostimaWikinovosti WikinovostiWikinovostimaWikinovostima
WikipediaWikipedijaWikipedijeWikipedijiWikipedijuWikipedijoWikipedijomWikipediji
WikiquoteWikicitatWikicitataWikicitatuWikicitatWikicitateWikicitatomWikicitatu
WikisourceWikitekaWikitekeWikiteciWikitekuWikitekoWikitekomWikiteci
WikispeciesWikivrsteWikivrstaWikivrstamaWikivrsteWikivrsteWikivrstamaWikivrstama
WikiversityWikiverzitetWikiverzitetaWikiverzitetuWikiverzitetWikiverziteteWikiverzitetomWikiverzitetu
WikivoyageWikivodičWikivodičaWikivodičuWikivodičWikivodičuWikivodičemWikivodiču
WiktionaryWikirječnikWikirječnikaWikirječnikuWikirječnikWikirječničeWikirječnikomWikirječniku

For other, non-included projects:

Englishbase wordgenitivdativakuzativvokativinstrumentallokativ
$1$1projekta $1projektu $1projekt $1projekte $1projektom $1projektu $1

Serbo-Croatian Cyrillic (sh-Cyrl):
(sorted by the English word for consistency, English terms bolded, italics = no changes)

Englishbase wordгенитивдативакузативвокативинструменталлокатив
WikibooksВикикњигеВикикњигаВикикњигамаВикикњигеВикикњигеВикикњигамаВикикњигама
WikidataВикиподациВикиподатакаВикиподацимаВикиподаткеВикиподациВикиподацимаВикиподацима
WikifunctionsВикифункцијеВикифункцијаВикифункцијамаВикифункцијеВикифункцијеВикифункцијамаВикифункцијама
Wikimedia Commons Викимедијина оставаВикимедијине оставеВикимедијиној оставиВикимедијину оставуВикимедијина оставоВикимедијином оставомВикимедијиној остави
WikinewsВикиновостиВикиновостиВикиновостимаВикиновости ВикиновостиВикиновостимаВикиновостима
WikipediaВикипедијаВикипедијеВикипедијиВикипедијуВикипедијоВикипедијомВикипедији
WikiquoteВикицитатВикицитатаВикицитатуВикицитатВикицитатеВикицитатомВикицитату
WikisourceВикитекаВикитекеВикитециВикитекуВикитекоВикитекомВикитеци
WikispeciesВикиврстеВикиврстаВикиврстамаВикиврстеВикиврстеВикиврстамаВикиврстама
WikiversityВикиверзитетВикиверзитетаВикиверзитетуВикиверзитетВикиверзитетеВикиверзитетомВикиверзитету
WikivoyageВикиводичВикиводичаВикиводичуВикиводичВикиводичуВикиводичемВикиводичу
WiktionaryВикиречникВикиречникаВикиречникуВикиречникВикиречничеВикиречникомВикиречнику

For other, non-included projects:

Englishbase wordгенитивдативакузативвокативинструменталлокатив
$1$1пројекта $1пројекту $1пројект $1пројекте $1пројектом $1пројекту $1
gerritbot added a comment.Feb 1 2025, 11:04 AM

Change #1116216 had a related patch set uploaded (by Msz2001; author: Msz2001):

[mediawiki/core@master] Add support for GRAMMAR in Serbo-Croatian

https://gerrit.wikimedia.org/r/1116216

gerritbot added a project: Patch-For-Review.Feb 1 2025, 11:04 AM

Change #1116217 had a related patch set uploaded (by Msz2001; author: Msz2001):

[mediawiki/extensions/WikimediaMessages@master] Add GRAMMAR table for Serbo-Croatian

https://gerrit.wikimedia.org/r/1116217

Msz2001 added a comment.EditedFeb 1 2025, 11:45 AM

I've prepared patches with the grammar rules. However, I've noticed two things that stem rather from the LanguageConverter behavior:

  • W is not converted to В, e.g. Wikipedija is rendered as Wикипедија
  • Wikirječnik is converted into Викирјечник (with ј)

Correcting those is unlikely to require additional fixes to grammar tables, as they appear to be applied before converting language variants.

Aca added a comment.Feb 1 2025, 6:10 PM

Yeah, actually, it seems like the LanguageCoverter doesn't support converting sitenames yet (T213578). For now, we can implement the Latin variants only.

PatchDemoBot added a comment.Feb 5 2025, 10:56 PM

Test wiki created on Patch demo by Aca using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/0b4830fab1/w/

Aca added a comment.Feb 5 2025, 11:16 PM

Working as intended on PatchDemo, will look for someone for +2

gerritbot added a comment.Feb 6 2025, 4:45 AM

Change #1116216 merged by jenkins-bot:

[mediawiki/core@master] Add support for GRAMMAR in Serbo-Croatian

https://gerrit.wikimedia.org/r/1116216

gerritbot added a comment.Feb 6 2025, 4:50 AM

Change #1116217 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Add GRAMMAR table for Serbo-Croatian

https://gerrit.wikimedia.org/r/1116217

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.16; 2025-02-11).Feb 6 2025, 5:00 AM
Aca added a comment.Feb 6 2025, 5:03 AM

Done, closing. Thanks for your help!

Aca closed this task as Resolved.Feb 6 2025, 5:04 AM
Aca assigned this task to Msz2001.
Maintenance_bot removed a project: Patch-For-Review.Feb 6 2025, 5:30 AM
Nikerabbit reopened this task as Open.Feb 26 2025, 8:58 AM
Nikerabbit added a project: affects-translatewiki.net.
Nikerabbit subscribed.

This causes:

[2025-02-26T08:53:46.150105+00:00] error.ERROR: [992b81cf82ffa6cd03b9b314] /wiki/MediaWiki:Visualeditor-welcomedialog-title/sh   PHP Warning: Undefined array key "sh" {"exception":"[object] (ErrorException(code: 0): PHP Warning: Undefined array key \"sh\" at /srv/mediawiki/workdir/includes/languages/LanguageSh.php:46)
[stacktrace]
#0 /srv/mediawiki/workdir/includes/languages/LanguageSh.php(46): MWExceptionHandler::handleError()
#1 /srv/mediawiki/workdir/includes/parser/CoreParserFunctions.php(406): LanguageSh->convertGrammar()
#2 /srv/mediawiki/workdir/includes/parser/Parser.php(3488): MediaWiki\\Parser\\CoreParserFunctions::grammar()
#3 /srv/mediawiki/workdir/includes/parser/Parser.php(3143): MediaWiki\\Parser\\Parser->callParserFunction()
#4 /srv/mediawiki/workdir/includes/parser/PPFrame_Hash.php(280): MediaWiki\\Parser\\Parser->braceSubstitution()
#5 /srv/mediawiki/workdir/includes/parser/Parser.php(2970): MediaWiki\\Parser\\PPFrame_Hash->expand()
#6 /srv/mediawiki/workdir/includes/parser/Parser.php(1602): MediaWiki\\Parser\\Parser->replaceVariables()
#7 /srv/mediawiki/workdir/includes/parser/Parser.php(701): MediaWiki\\Parser\\Parser->internalParse()
#8 /srv/mediawiki/workdir/includes/Output/OutputPage.php(2683): MediaWiki\\Parser\\Parser->parse()
#9 /srv/mediawiki/workdir/includes/Output/OutputPage.php(2237): MediaWiki\\Output\\OutputPage->parseInternal()
#10 /srv/mediawiki/workdir/includes/Output/OutputPage.php(2218): MediaWiki\\Output\\OutputPage->addWikiTextTitleInternal()
#11 /srv/mediawiki/workdir/includes/page/Article.php(1650): MediaWiki\\Output\\OutputPage->addWikiTextAsContent()
#12 /srv/mediawiki/workdir/includes/page/Article.php(718): Article->showMissingArticle()
#13 /srv/mediawiki/workdir/includes/page/Article.php(546): Article->generateContentOutput()
#14 /srv/mediawiki/workdir/includes/actions/ViewAction.php(78): Article->view()
#15 /srv/mediawiki/workdir/includes/actions/ActionEntryPoint.php(732): ViewAction->show()
#16 /srv/mediawiki/workdir/includes/actions/ActionEntryPoint.php(509): MediaWiki\\Actions\\ActionEntryPoint->performAction()
#17 /srv/mediawiki/workdir/includes/actions/ActionEntryPoint.php(145): MediaWiki\\Actions\\ActionEntryPoint->performRequest()
#18 /srv/mediawiki/workdir/includes/MediaWikiEntryPoint.php(202): MediaWiki\\Actions\\ActionEntryPoint->execute()
#19 /srv/mediawiki/workdir/index.php(58): MediaWiki\\MediaWikiEntryPoint->run()
#20 {main}
","exception_url":"/wiki/MediaWiki:Visualeditor-welcomedialog-title/sh","reqId":"992b81cf82ffa6cd03b9b314","caught_by":"mwe_handler"} []
[26-Feb-2025 08:53:46 UTC] PHP Warning:  Undefined array key "sh" in /srv/mediawiki/workdir/includes/languages/LanguageSh.php on line 46
[2025-02-26T08:53:46.150495+00:00] error.ERROR: [992b81cf82ffa6cd03b9b314] /wiki/MediaWiki:Visualeditor-welcomedialog-title/sh   PHP Warning: foreach() argument must be of type array|object, null given {"exception":"[object] (ErrorException(code: 0): PHP Warning: foreach() argument must be of type array|object, null given at /srv/mediawiki/workdir/includes/languages/LanguageSh.php:46)
[stacktrace]
#0 /srv/mediawiki/workdir/includes/languages/LanguageSh.php(46): MWExceptionHandler::handleError()
#1 /srv/mediawiki/workdir/includes/parser/CoreParserFunctions.php(406): LanguageSh->convertGrammar()
#2 /srv/mediawiki/workdir/includes/parser/Parser.php(3488): MediaWiki\\Parser\\CoreParserFunctions::grammar()
#3 /srv/mediawiki/workdir/includes/parser/Parser.php(3143): MediaWiki\\Parser\\Parser->callParserFunction()
#4 /srv/mediawiki/workdir/includes/parser/PPFrame_Hash.php(280): MediaWiki\\Parser\\Parser->braceSubstitution()
#5 /srv/mediawiki/workdir/includes/parser/Parser.php(2970): MediaWiki\\Parser\\PPFrame_Hash->expand()
#6 /srv/mediawiki/workdir/includes/parser/Parser.php(1602): MediaWiki\\Parser\\Parser->replaceVariables()
#7 /srv/mediawiki/workdir/includes/parser/Parser.php(701): MediaWiki\\Parser\\Parser->internalParse()
#8 /srv/mediawiki/workdir/includes/Output/OutputPage.php(2683): MediaWiki\\Parser\\Parser->parse()
#9 /srv/mediawiki/workdir/includes/Output/OutputPage.php(2237): MediaWiki\\Output\\OutputPage->parseInternal()
#10 /srv/mediawiki/workdir/includes/Output/OutputPage.php(2218): MediaWiki\\Output\\OutputPage->addWikiTextTitleInternal()
#11 /srv/mediawiki/workdir/includes/page/Article.php(1650): MediaWiki\\Output\\OutputPage->addWikiTextAsContent()
#12 /srv/mediawiki/workdir/includes/page/Article.php(718): Article->showMissingArticle()
#13 /srv/mediawiki/workdir/includes/page/Article.php(546): Article->generateContentOutput()
#14 /srv/mediawiki/workdir/includes/actions/ViewAction.php(78): Article->view()
#15 /srv/mediawiki/workdir/includes/actions/ActionEntryPoint.php(732): ViewAction->show()
#16 /srv/mediawiki/workdir/includes/actions/ActionEntryPoint.php(509): MediaWiki\\Actions\\ActionEntryPoint->performAction()
#17 /srv/mediawiki/workdir/includes/actions/ActionEntryPoint.php(145): MediaWiki\\Actions\\ActionEntryPoint->performRequest()
#18 /srv/mediawiki/workdir/includes/MediaWikiEntryPoint.php(202): MediaWiki\\Actions\\ActionEntryPoint->execute()
#19 /srv/mediawiki/workdir/index.php(58): MediaWiki\\MediaWikiEntryPoint->run()
#20 {main}
","exception_url":"/wiki/MediaWiki:Visualeditor-welcomedialog-title/sh","reqId":"992b81cf82ffa6cd03b9b314","caught_by":"mwe_handler"} []
gerritbot added a comment.Feb 26 2025, 7:11 PM

Change #1123019 had a related patch set uploaded (by Msz2001; author: Msz2001):

[mediawiki/core@master] Fix warning that $grammarForms['sh'] is undefined

https://gerrit.wikimedia.org/r/1123019

gerritbot added a project: Patch-For-Review.Feb 26 2025, 7:11 PM
gerritbot added a comment.Feb 27 2025, 1:38 PM

Change #1123019 merged by jenkins-bot:

[mediawiki/core@master] Fix warning that $grammarForms['sh'] is undefined

https://gerrit.wikimedia.org/r/1123019

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.19; 2025-03-04); removed MW-1.44-notes (1.44.0-wmf.16; 2025-02-11).Feb 27 2025, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 27 2025, 2:30 PM
Aca added a comment.Apr 20 2025, 12:16 PM

@Msz2001 This can be closed now, I guess?

Msz2001 closed this task as Resolved.Apr 20 2025, 12:18 PM

Oh, right. I completely forgot about that.

PatchDemoBot added a comment.Jun 18 2025, 8:46 PM

Test wiki on Patch demo by Aca using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org//wikis/0b4830fab1/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits