for hosts i think we may be able to get the parent which would be a much better way of doing this? (we still need to talk about how we do that for net devices)

Another way to turn the question is: 'what "locations" should match to?' and apply it consistently. To me, 1:1 match to rows is not relevant anymore.

Indeed your suggestion is good for this specific usecase (network maintenance).
to get all physical devices connected to a given ToR. The LLDP parent is already in PuppetDB, eg. https://puppetboard.wikimedia.org/node/netmon1003.wikimedia.org parent : asw2-b-eqiad.mgmt.eqiad.wmnet is it possible to filter on it using Cumin?
However it gets more complex when doing VMs, but in that case we can rely on the existing Ganeti cluster location selector.

In T333948#8757652, @ayounsi wrote:

Another way to turn the question is: 'what "locations" should match to?' and apply it consistently. To me, 1:1 match to rows is not relevant anymore.

I started this bit trying to describe the current data structure but i think that it might be better for you to say what you need/is useful and we can adjust to that. ill say that the current structure was designed with the following considerations:

• for VM's its general more useful to know about the vm host then the actual rack/row (we could probably add the later with some munging)
• site/datacenter is genrally useful and it would be great to replace the $::site global
• rack is useful for rack aware services e.g. Cassandra
• row ise useful to combine it with rack to get a unique rack i.e. ensure a box in A1 is not considered in the same rack as B1

AFAIK this info is not been used yet but we should keep the Cassandra use case in mind

Indeed your suggestion is good for this specific usecase (network maintenance).
to get all physical devices connected to a given ToR. The LLDP parent is already in PuppetDB, eg. https://puppetboard.wikimedia.org/node/netmon1003.wikimedia.org parent : asw2-b-eqiad.mgmt.eqiad.wmnet is it possible to filter on it using Cumin?

ish, currently cumin doesn't have good support for structured facts but we can use a pattern on the lldp fact e.g. sudo cumin 'F:lldp ~ "parent.+asw2-b-eqiad.mgmt.eqiad.wmnet"' . We cold improve this by creating a legacy fact for lldp_parent which would allow us to do sudo cumin 'F:lldp_parent = "asw2-c-eqiad.mgmt.eqiad.wmnet"' this is a simple change so just let me know if its useful

However it gets more complex when doing VMs, but in that case we can rely on the existing Ganeti cluster location selector.

exactly and we can use the same fact e.g. sudo cumin 'F:lldp ~ "parent.+ganeti1024.eqiad.wmnet"'