PHP Notice: Array to string conversion (WikibaseRepo.DataValueDeserializer service wiring)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Someone’s making wbformatvalue API requests with a datavalue parameter that decodes to {"value":{"id":{"isTrusted":true}},"type":"wikibase-entityid"}; this causes a PHP notice here:

WikibaseRepo.ServiceWiring.php 'WikibaseRepo.DataValueDeserializer'

throw new InvalidArgumentException(
	'Can not parse id \'' . $value['id'] . '\' to build EntityIdValue with',
	0,
	$parsingException
);

Error

mwversion: 1.41.0-wmf.4
reqId: 3e1a0eaf-82fd-4a20-a507-6d3d82d47ec7
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Array to string conversion

exception.trace

from /srv/mediawiki/php-1.41.0-wmf.4/extensions/Wikibase/repo/WikibaseRepo.ServiceWiring.php(507)
#0 /srv/mediawiki/php-1.41.0-wmf.4/extensions/Wikibase/repo/WikibaseRepo.ServiceWiring.php(507): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.41.0-wmf.4/vendor/data-values/serialization/src/Deserializers/DataValueDeserializer.php(122): Wikimedia\Services\ServiceContainer::{closure}(array)
#2 /srv/mediawiki/php-1.41.0-wmf.4/vendor/data-values/serialization/src/Deserializers/DataValueDeserializer.php(91): DataValues\Deserializers\DataValueDeserializer->getDeserialization(array)
#3 /srv/mediawiki/php-1.41.0-wmf.4/extensions/Wikibase/lib/includes/DataValueFactory.php(44): DataValues\Deserializers\DataValueDeserializer->deserialize(array)
#4 /srv/mediawiki/php-1.41.0-wmf.4/extensions/Wikibase/lib/includes/DataValueFactory.php(75): Wikibase\Lib\DataValueFactory->newDataValue(string, array)
#5 /srv/mediawiki/php-1.41.0-wmf.4/extensions/Wikibase/repo/includes/Api/FormatSnakValue.php(248): Wikibase\Lib\DataValueFactory->newFromArray(array)
#6 /srv/mediawiki/php-1.41.0-wmf.4/extensions/Wikibase/repo/includes/Api/FormatSnakValue.php(143): Wikibase\Repo\Api\FormatSnakValue->decodeDataValue(string)
#7 /srv/mediawiki/php-1.41.0-wmf.4/includes/api/ApiMain.php(1908): Wikibase\Repo\Api\FormatSnakValue->execute()
#8 /srv/mediawiki/php-1.41.0-wmf.4/includes/api/ApiMain.php(884): ApiMain->executeAction()
#9 /srv/mediawiki/php-1.41.0-wmf.4/includes/api/ApiMain.php(855): ApiMain->executeActionWithErrorHandling()
#10 /srv/mediawiki/php-1.41.0-wmf.4/api.php(91): ApiMain->execute()
#11 /srv/mediawiki/php-1.41.0-wmf.4/api.php(46): wfApiMain()
#12 /srv/mediawiki/w/api.php(3): require(string)
#13 {main}

Impact

Minor logspam. No user impact.

Notes

Details

Request URL: https://www.wikidata.org/w/api.php?action=wbformatvalue&datatype=*&datavalue=*&errorformat=*&format=*&generate=*&options=*&uselang=*

	Subject	Repo	Branch	Lines +/-
	Avoid array to string conversion in DataValueDeserializer	mediawiki/extensions/Wikibase	master	+28 -1

Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 14 2023, 10:42 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2023, 10:42 AM

Change 908797 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Avoid array to string conversion in DataValueDeserializer

https://gerrit.wikimedia.org/r/908797

gerritbot added a project: Patch-For-Review.Apr 14 2023, 10:51 AM

Lucas_Werkmeister_WMDE claimed this task.Apr 14 2023, 10:51 AM

Change 908797 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Avoid array to string conversion in DataValueDeserializer

https://gerrit.wikimedia.org/r/908797

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 17 2023, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Apr 17 2023, 11:10 AM

Looks like the fix works on Test Wikidata, I think that’s enough to close this task. It’ll roll out with the train over the rest of the week.

PHP Notice: Array to string conversion (WikibaseRepo.DataValueDeserializer service wiring)Closed, ResolvedPublicPRODUCTION ERRORActions