Page MenuHomePhabricator
Create Task
Maniphest T334755

CargoQueryAPI doesn't expose error when a disallowed field alias is used
Closed, ResolvedPublic
Actions

Description

action=cargoquery rejects queries that contain field aliases starting with an underscore (_). However, if the wiki is configured to not display exception details to everyone, this error is not visible to the user that issued the API request. This can cause confusion.

Cargo should expose this error message so that users can fix their API call accordingly.

Details

SubjectRepoBranchLines +/-
CargoQueryAPI: Expose field alias errorsmediawiki/extensions/Cargomaster+50 -3
Customize query in gerrit

Event Timeline

TK-999 created this task.Apr 14 2023, 4:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2023, 4:04 PM
gerritbot added a comment.Apr 14 2023, 4:04 PM

Change 908894 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/extensions/Cargo@master] CargoQueryAPI: Expose field alias errors

https://gerrit.wikimedia.org/r/908894

gerritbot added a project: Patch-For-Review.Apr 14 2023, 4:04 PM
gerritbot added a comment.Apr 14 2023, 8:07 PM

Change 908894 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] CargoQueryAPI: Expose field alias errors

https://gerrit.wikimedia.org/r/908894

Maintenance_bot removed a project: Patch-For-Review.Apr 14 2023, 8:10 PM
TK-999 closed this task as Resolved.Apr 17 2023, 9:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL