Page MenuHomePhabricator

tests.wikibase_tests.TestLoadRevisionsCaching needs up to 3 minutes to be finished
Closed, ResolvedPublic

Description

tests.wikibase_tests.TestLoadRevisionsCaching needs up to 3 minutes to be finished

D:\pwb\GIT\core>pwb wikibase_tests -v TestLoadRevisionsCaching
tests: max_retries reduced from 15 to 1
test_page_text (__main__.TestLoadRevisionsCaching.test_page_text)
Test site.loadrevisions() with Page.text. ... 
 113.794s ok

----------------------------------------------------------------------
Ran 1 test in 115.057s

OK

D:\pwb\GIT\core>

The test is made for Q60 and the assertEqual method to compare the dicts needs a long time. As this test was introduced the Q60 item had only a fraction of the current size.

Event Timeline

Xqt triaged this task as Medium priority.Apr 16 2023, 10:39 AM
Xqt added a project: Performance Issue.

Change 908983 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] use Q15169668 item for wikibase_tests.py

https://gerrit.wikimedia.org/r/908983

Change 908983 merged by jenkins-bot:

[pywikibot/core@master] [tests] use Q15169668 item for wikibase_tests.py

https://gerrit.wikimedia.org/r/908983