Created attachment 9183
Patch for regular expression problem

Attached:

$.escapeRE() should be fixed here. I'll investigate.

$.escapeRE("http://mywiki.com/wiki/$1")

"http://mywiki\.com/wiki/\$1"

Is what I get in trunk (where $.escapeRE() has been moved to trunk/phase3/resources/jquery/jquery.mwExtension.js). Which version did you get your results on?

I am using 1.17.0. Firebug gives the buggy results:

$.escapeRE("http://mywiki.com/wiki/$1");

"http\:\/\/mywiki\.com\/wiki\/\$\1"

When I hit English Wikipedia and check against 1.18.0wmf, I get correct results:

$.escapeRE("http://mywiki.com/wiki/$1");

"http://mywiki\.com/wiki/\$1"

There might still be a problem on English Wikipedia however, because of the following use case:

0. Visit en.wikipedia.org and edit any page.

1. Click the Link button in the editor.
2. Enter http://en.wikipedia.org/wiki/Dog as the link and click "Insert link".
3. You *should* get a pop-up dialog that says "The URL you specified looks like it was intended as a link to another wiki page. Do you want to make it an internal link?" (message MediaWiki:Wikieditor-toolbar-tool-link-lookslikeinternal), however no dialog appears.

(In reply to comment #4)

I am using 1.17.0. Firebug gives the buggy results:

$.escapeRE("http://mywiki.com/wiki/$1");

"http\:\/\/mywiki\.com\/wiki\/\$\1"

When I hit English Wikipedia and check against 1.18.0wmf, I get correct
results:

$.escapeRE("http://mywiki.com/wiki/$1");

"http://mywiki\.com/wiki/\$1"

There might still be a problem on English Wikipedia however, because of the
following use case:

0. Visit en.wikipedia.org and edit any page.

1. Click the Link button in the editor.
2. Enter http://en.wikipedia.org/wiki/Dog as the link and click "Insert link".
3. You *should* get a pop-up dialog that says "The URL you specified looks like

it was intended as a link to another wiki page. Do you want to make it an
internal link?" (message
MediaWiki:Wikieditor-toolbar-tool-link-lookslikeinternal), however no dialog
appears.

Hah, that's probably because wgServer is protocol-relative now:

mw.config.get('wgServer')

"//en.wikipedia.org"

Fixed in r100699.