Maniphest T336267

styles, mixins: Rename `.cdx-mixin-button-css-icon-background-color`
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Volker_E
	May 9 2023, 1:57 PM

Tags

Referenced Files

None

Subscribers

Description

Background

.cdx-mixin-button-css-icon-background-color() mixin has been introduced to provide a fallback for browsers not supporting mask-image.
As it consumes only foreground colors for icon coloring the name is confusing when using tokens.

Proposals

.cdx-mixin-button-css-icon-fallback-color() – best compromise IMO
.cdx-mixin-button-css-icon-mask-fallback-color() – descriptive but too complex
.cdx-mixin-button-css-icon-mask-color() – doesn't work as it's not the mask color

Acceptance criteria

Rename the mixin in Codex

Event Timeline

Volker_E created this task.May 9 2023, 1:57 PM

Restricted Application triaged this task as High priority. · View Herald TranscriptMay 9 2023, 1:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 917894 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] styles, mixins: Name icon fallback mixin more appropriately

https://gerrit.wikimedia.org/r/917894

gerritbot added a project: Patch-For-Review.May 9 2023, 2:05 PM

Volker_E claimed this task.May 9 2023, 2:09 PM

Volker_E moved this task from Committed to Code Review on the Design-System-Team (Design-System-Sprint) board.

Volker_E set the point value for this task to 1.

Change 917894 merged by jenkins-bot:

[design/codex@main] styles, mixins: Name icon fallback mixin more appropriately

https://gerrit.wikimedia.org/r/917894

Maintenance_bot removed a project: Patch-For-Review.May 9 2023, 6:10 PM

Volker_E updated the task description. (Show Details)May 9 2023, 6:28 PM

Volker_E moved this task from Code Review to Pending Release on the Design-System-Team (Design-System-Sprint) board.

Change 918598 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.9.1 to v0.10.0

https://gerrit.wikimedia.org/r/918598

gerritbot added a project: Patch-For-Review.May 10 2023, 8:45 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/8333e57f25/w

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/8333e57f25/w/~~

Change 918598 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.9.1 to v0.10.0

https://gerrit.wikimedia.org/r/918598

Maintenance_bot removed a project: Patch-For-Review.May 11 2023, 5:11 PM

Volker_E closed this task as Resolved.May 15 2023, 4:42 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 8:02 PM