PHPUnit reports deprecation notice about mismatched test case class filename from GlobalFunctions tests
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Umherirrender
	May 23 2023, 7:03 PM

Description

# php tests\phpunit\phpunit.php tests\phpunit\includes\GlobalFunctions
Using PHP 8.1.8
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

Warning:       Test case class not matching filename is deprecated
               in tests\phpunit\includes\GlobalFunctions\wfParseUrlTest.php
               Class name was 'WfParseUrlTest', expected 'wfParseUrlTest'
Warning:       Test case class not matching filename is deprecated
               in tests\phpunit\includes\GlobalFunctions\wfShellExecTest.php
               Class name was 'WfShellExecTest', expected 'wfShellExecTest'
Warning:       Test case class not matching filename is deprecated
               in tests\phpunit\includes\GlobalFunctions\wfThumbIsStandardTest.php
               Class name was 'WfThumbIsStandardTest', expected 'wfThumbIsStandardTest'

...............................................................  63 / 449 ( 14%)
................SSS............................................ 126 / 449 ( 28%)
............................................................... 189 / 449 ( 42%)
............................................................... 252 / 449 ( 56%)
............................................................... 315 / 449 ( 70%)
............................................................... 378 / 449 ( 84%)
.........................................................S..... 441 / 449 ( 98%)
........                                                        449 / 449 (100%)

Time: 00:05.186, Memory: 66.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 449, Assertions: 458, Skipped: 4.

Never seen on CI so this could just be a windows problem (handling file names case-insensitive)

https://github.com/sebastianbergmann/phpunit/commit/a1279f1d734f6fbd6a6e900f7a24b3b9767e9cac

Details

Subject	Repo	Branch	Lines +/-
tests: Resolve phpunit filename deprecation errors	mediawiki/extensions/Echo	master	+9 -5
tests: Resolve phpunit filename deprecation errors	mediawiki/extensions/Flow	master	+3 -3
tests: Resolve maintenance phpunit filename deprecation errors	mediawiki/core	master	+0 -2
Resolve GlobalFunctions phpunit filename deprecation errors	mediawiki/core	master	+0 -3

Customize query in gerrit

Event Timeline

Umherirrender created this task.May 23 2023, 7:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2023, 7:03 PM

I'm seeing similar behavior in my environment on Linux:

~/src/wikimedia/core/tests/phpunit $ php phpunit.php unit/includes/GlobalFunctions/
Using PHP 8.1.19                                                     
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.                                                                                    
                                                                                                                                          
Warning:       Test case class not matching filename is deprecated
               in /home/nik/src/wikimedia/core/tests/phpunit/unit/includes/GlobalFunctions/wfAppendQueryTest.php
               Class name was 'WfAppendQueryTest', expected 'wfAppendQueryTest'
Warning:       Test case class not matching filename is deprecated
               in /home/nik/src/wikimedia/core/tests/phpunit/unit/includes/GlobalFunctions/wfArrayPlus2dTest.php
               Class name was 'WfArrayPlus2dTest', expected 'wfArrayPlus2dTest' 
Warning:       Test case class not matching filename is deprecated                                                                        
               in /home/nik/src/wikimedia/core/tests/phpunit/unit/includes/GlobalFunctions/wfAssembleUrlTest.php
               Class name was 'WfAssembleUrlTest', expected 'wfAssembleUrlTest' 
Warning:       Test case class not matching filename is deprecated                                                                        
               in /home/nik/src/wikimedia/core/tests/phpunit/unit/includes/GlobalFunctions/wfBaseNameTest.php
               Class name was 'WfBaseNameTest', expected 'wfBaseNameTest'       
Warning:       Test case class not matching filename is deprecated

(etc.)

Change 929029 had a related patch set uploaded (by Nnyby; author: Nnyby):

[mediawiki/core@master] Resolve phpunit filename deprecation errors

https://gerrit.wikimedia.org/r/929029

gerritbot added a project: Patch-For-Review.Jun 11 2023, 9:48 PM

Nnyby moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jun 11 2023, 9:53 PM

Change 929029 merged by jenkins-bot:

[mediawiki/core@master] Resolve GlobalFunctions phpunit filename deprecation errors

https://gerrit.wikimedia.org/r/929029

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jul 1 2023, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 1 2023, 10:10 AM

Change 936383 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Resolve maintenance phpunit filename deprecation errors

https://gerrit.wikimedia.org/r/936383

gerritbot added a project: Patch-For-Review.Jul 9 2023, 8:34 PM

Change 936383 merged by jenkins-bot:

[mediawiki/core@master] tests: Resolve maintenance phpunit filename deprecation errors

https://gerrit.wikimedia.org/r/936383

Umherirrender closed this task as Resolved.Jul 12 2023, 9:44 PM

Umherirrender removed a project: Patch-For-Review.

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.18; 2023-07-18); removed MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jul 12 2023, 10:00 PM

Change 948212 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Flow@master] tests: Resolve phpunit filename deprecation errors

https://gerrit.wikimedia.org/r/948212

gerritbot added a project: Patch-For-Review.Aug 12 2023, 6:59 PM

Change 948213 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Echo@master] tests: Resolve phpunit filename deprecation errors

https://gerrit.wikimedia.org/r/948213

Change 948212 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] tests: Resolve phpunit filename deprecation errors

https://gerrit.wikimedia.org/r/948212

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Aug 12 2023, 10:00 PM

Change 948213 merged by jenkins-bot: