Page MenuHomePhabricator
Create Task
Maniphest T337373

IP information tool: url's to global contributions and XTools do not work but link to user "null"
Closed, ResolvedPublicBUG REPORT
Actions

Description

When using the IP information tool, the links to global contributions and XTools do not work. They include "null" instead of the IP.

Examples:

To be able to see this, make sure to enable the IP Information beta feature in your preferences.

Instead of "null", it should be the actual ip adress. Then, the link works as intended.

Details

SubjectRepoBranchLines +/-
ipInfo.hooks: Use wgRelevantUserNamemediawiki/extensions/WikimediaMessageswmf/1.41.0-wmf.9+2 -2
ipInfo.hooks: Use wgRelevantUserNamemediawiki/extensions/WikimediaMessageswmf/1.41.0-wmf.10+2 -2
ipInfo.hooks: Use wgRelevantUserNamemediawiki/extensions/WikimediaMessagesmaster+2 -2
Customize query in gerrit

Event Timeline

Ennomien created this task.May 24 2023, 9:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2023, 9:25 AM
TheresNoTime claimed this task.May 24 2023, 4:38 PM
gerritbot added a comment.May 24 2023, 4:44 PM

Change 922903 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/WikimediaMessages@master] ipInfo.hooks: Use wgRelevantUserName

https://gerrit.wikimedia.org/r/922903

gerritbot added a project: Patch-For-Review.May 24 2023, 4:44 PM
PatchDemoBot added a comment.May 24 2023, 4:47 PM

Test wiki created on Patch demo by TheresNoTime using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/26f3e4f51f/w

gerritbot added a comment.May 24 2023, 5:35 PM

Change 922903 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] ipInfo.hooks: Use wgRelevantUserName

https://gerrit.wikimedia.org/r/922903

PatchDemoBot added a comment.May 24 2023, 5:41 PM

Test wiki on Patch demo by TheresNoTime using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/26f3e4f51f/w/

gerritbot added a comment.May 24 2023, 5:52 PM

Change 922854 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/WikimediaMessages@wmf/1.41.0-wmf.10] ipInfo.hooks: Use wgRelevantUserName

https://gerrit.wikimedia.org/r/922854

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.11; 2023-05-30).May 24 2023, 6:00 PM
gerritbot added a comment.May 24 2023, 8:14 PM

Change 922855 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/WikimediaMessages@wmf/1.41.0-wmf.9] ipInfo.hooks: Use wgRelevantUserName

https://gerrit.wikimedia.org/r/922855

gerritbot added a comment.May 24 2023, 8:16 PM

Change 922854 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@wmf/1.41.0-wmf.10] ipInfo.hooks: Use wgRelevantUserName

https://gerrit.wikimedia.org/r/922854

Stashbot added a comment.May 24 2023, 8:16 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-24T20:16:36Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:922854|ipInfo.hooks: Use wgRelevantUserName (T337373)]]

Stashbot added a comment.May 24 2023, 8:18 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-24T20:18:05Z] <samtar@deploy1002> samtar: Backport for [[gerrit:922854|ipInfo.hooks: Use wgRelevantUserName (T337373)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.May 24 2023, 8:25 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-24T20:25:07Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:922854|ipInfo.hooks: Use wgRelevantUserName (T337373)]] (duration: 08m 31s)

gerritbot added a comment.May 24 2023, 8:46 PM

Change 922855 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@wmf/1.41.0-wmf.9] ipInfo.hooks: Use wgRelevantUserName

https://gerrit.wikimedia.org/r/922855

Stashbot added a comment.May 24 2023, 8:47 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-24T20:47:05Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:922855|ipInfo.hooks: Use wgRelevantUserName (T337373)]]

Stashbot added a comment.May 24 2023, 8:48 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-24T20:48:34Z] <samtar@deploy1002> samtar: Backport for [[gerrit:922855|ipInfo.hooks: Use wgRelevantUserName (T337373)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.May 24 2023, 8:55 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-24T20:55:20Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:922855|ipInfo.hooks: Use wgRelevantUserName (T337373)]] (duration: 08m 15s)

TheresNoTime closed this task as Resolved.May 24 2023, 8:57 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.9; 2023-05-15); removed MW-1.41-notes (1.41.0-wmf.11; 2023-05-30).May 24 2023, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 24 2023, 9:10 PM
Ennomien added a comment.May 24 2023, 10:21 PM

Thanks for solving, I see it's even updated on the "real" Wikipedia already.

But was it really needed to send me 19 emails about this? Why can't I choose to receive a daily/weekly update on my email? I want updates about topics I follow on phabricator, but 19 emails is a bit overwhelming. Anyone an idea?

TheresNoTime added a comment.May 24 2023, 10:24 PM
In T337373#8878536, @Ennomien wrote:

But was it really needed to send me 19 emails about this?

Sorry! The Phabricator defaults for sending emails isn't the best — https://www.mediawiki.org/wiki/Phabricator/Help/Managing_mail has some steps you can take to limit the number of emails you recieve (I use Phabricator a lot, so ended up turning off all emails otherwise it would be 100s!)

Ennomien added a comment.May 24 2023, 10:56 PM

Thanks. Well, I think I have to take it for granted then. Hoped there were some more options. Almost all emails were about comments added, but I don't want to miss áll comments. Some specific comments above are interesting for me, but not all.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits