Improve error handling in "Escalate security issue" code
Closed, ResolvedPublicFeature
Actions

Assigned To

Authored By

	Aklapper
	May 28 2023, 9:17 PM

Description

Steps to reproduce:

Go to test instance at https://phab.wmflabs.org/T106
Select Protect as security issue in the sidebar
In the Escalate security issue overlay dialog, select the Escalate button

Actual outcome:

Unhandled Exception ("Error")
Call to a member function getPHID() on null

Expected outcome:
A reasonable error message explaining what's the issue when running a test instance: Project tags are hardcoded, thus they don't necessarily exist in a test instance and someone needs to create them first.

Details

	Title	Reference	Author	Source Branch	Dest Branch
	Improve error handling in "Escalate security issue" code	repos/phabricator/extensions!22	aklapper	T337654	wmf/stable
	Improve error handling in "Escalate security issue" code	repos/phabricator/extensions!8	aklapper	aklapper-wmf/stable-patch-72396	wmf/stable

Customize query in GitLab

Related Objects

Mentioned In: T198589: Replace project names by PHIDs in our Phab extensions

Event Timeline

Aklapper created this task.May 28 2023, 9:17 PM

Aklapper claimed this task.May 28 2023, 9:21 PM

Aklapper triaged this task as Low priority.

Aklapper edited projects, added Release-Engineering-Team, Wikimedia-Phabricator-Extensions; removed Phabricator.

aklapper opened https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/8

Improve error handling in "Escalate security issue" code

CodeReviewBot added a project: Patch-For-Review.May 28 2023, 9:22 PM

Aklapper edited projects, added Release-Engineering-Team (They Live 🕶️🧟); removed Release-Engineering-Team.Jun 7 2023, 3:18 PM

jeena moved this task from Backlog to Waiting for review on the Release-Engineering-Team (They Live 🕶️🧟) board.Jun 12 2023, 9:06 PM

thcipriani edited projects, added Release-Engineering-Team (Escape Goats🐐); removed Release-Engineering-Team (They Live 🕶️🧟).Jul 26 2023, 2:52 PM

thcipriani moved this task from Backlog to Waiting for review on the Release-Engineering-Team (Escape Goats🐐) board.Jul 26 2023, 3:21 PM

Aklapper mentioned this in T198589: Replace project names by PHIDs in our Phab extensions.Sep 15 2023, 3:33 PM

aklapper closed https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/8

Improve error handling in "Escalate security issue" code

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2023, 12:10 PM

Note to myself: The GitLab UI when deleting personal projects is not particularly clear when it displays "0 patches, 0 issues, 0 etc" etc. I did not realize that this message does not cover open merge requests for the main branch, so I need to re-do this patch...

aklapper opened https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/22

Improve error handling in "Escalate security issue" code

thcipriani edited projects, added Release-Engineering-Team (Priority Backlog 📥); removed Release-Engineering-Team (Escape Goats🐐).Oct 18 2023, 3:17 PM

brennen merged https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/22

Improve error handling in "Escalate security issue" code

Maintenance_bot removed a project: Patch-For-Review.Mon, Apr 15, 7:31 PM

Aklapper added a project: Phabricator (2024-04-16).Tue, Apr 16, 6:38 AM