Page MenuHomePhabricator

Allow setting draining strategy and time in envoy image
Closed, ResolvedPublic

Description

In order to gracefully handle pod termination in mw-on-k8s, envoy needs:

  • A draining script
  • A way to set --drain-time-s and --drain-strategy envoy CLI options

Event Timeline

Clement_Goubert changed the task status from Open to In Progress.Jun 2 2023, 9:44 AM
Clement_Goubert triaged this task as High priority.
Clement_Goubert created this task.
Clement_Goubert moved this task from Incoming 🐫 to Doing 😎 on the serviceops board.

Change 926455 had a related patch set uploaded (by Clément Goubert; author: Clément Goubert):

[operations/docker-images/production-images@master] envoy: Add draining script and configuration

https://gerrit.wikimedia.org/r/926455

Change 926455 merged by Clément Goubert:

[operations/docker-images/production-images@master] envoy: Add draining script and configuration

https://gerrit.wikimedia.org/r/926455

Mentioned in SAL (#wikimedia-operations) [2023-06-06T09:11:07Z] <claime> Building production images - T338014

Setting the following environment variables now controls envoy's draining behaviour:
DRAIN_TIME_S
DRAIN_STRATEGY

In case a non-default admin port is used, the ADMIN_PORT environment variable has to be set for the drain-envoy.sh script to work.

Change 927997 had a related patch set uploaded (by Clément Goubert; author: Clément Goubert):

[operations/docker-images/production-images@master] envoy: Add connection tracking to drain-envoy.sh

https://gerrit.wikimedia.org/r/927997

Change 927997 merged by Clément Goubert:

[operations/docker-images/production-images@master] envoy: Add connection tracking to drain-envoy.sh

https://gerrit.wikimedia.org/r/927997