Incorrect normalization of pywikibot.WbTime
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Multichill
	Jun 26 2023, 10:11 PM

Description

I noticed my bot doing weird edits like https://www.wikidata.org/w/index.php?title=Q2270291&diff=prev&oldid=1924431056 . Here the bot should have changed it to 1598, but for some reason it change it to 2000. This is incorrect behavior. This normalization shouldn't happen. Found the problem at https://github.com/wikimedia/pywikibot/blob/master/pywikibot/page/_wikibase.py#L1982 . normalize shouldn't be true.

Bug seems to be introduced in T325860 / https://gerrit.wikimedia.org/r/c/pywikibot/core/+/872504/

Details

	Subject	Repo	Branch	Lines +/-
	Revert "[Bugfix] Normalize WbTimes sent to Wikidata"	pywikibot/core	master	+13 -27
	Remove incorrect time normalization	pywikibot/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T325860: Unable to submit any pywikibot.WbTime with hour/minute/second even if precision is day or lower
Mentioned Here: T57755: Allow time values more precise than day on Wikidata
T325860: Unable to submit any pywikibot.WbTime with hour/minute/second even if precision is day or lower

Event Timeline

Multichill created this task.Jun 26 2023, 10:11 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJun 26 2023, 10:11 PM

https://www.wikidata.org/w/index.php?title=Q118631862&diff=prev&oldid=1924443167 is what is supposed to happen

I mean it partially isn’t a bug as the precision is set to millennium. If you want a more specific date value then the precision should be updated to be more precise. 2000 and 1500 are in the same millennium, the 2nd millennium.

Xqt triaged this task as High priority.Jun 27 2023, 2:06 AM

This is a bug. This causes bots to butcher up dates. Say for example a painting is sourced to be made between 1190 and 1210. The year will be set to 1200 with a precision of a millennium with earliest date 1190 and latest date 1210. The 1200 is used for sorting and other cases where things are just grouped together. This would be changed to 2000 with the current logic. This is not in line with https://www.wikidata.org/wiki/Help:Dates .

Change 934692 had a related patch set uploaded (by Multichill; author: Multichill):

[pywikibot/core@master] Remove incorrect time normalization

https://gerrit.wikimedia.org/r/934692

gerritbot added a project: Patch-For-Review.Jul 2 2023, 10:55 AM

Xqt closed this task as Resolved.Jul 2 2023, 3:45 PM

Xqt claimed this task.

Change 934692 merged by jenkins-bot:

[pywikibot/core@master] Remove incorrect time normalization

https://gerrit.wikimedia.org/r/934692

Maintenance_bot removed a project: Patch-For-Review.Jul 2 2023, 4:10 PM

Xqt mentioned this in T325860: Unable to submit any pywikibot.WbTime with hour/minute/second even if precision is day or lower.Jul 2 2023, 4:37 PM

Change 934708 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] Revert "[Bugfix] Normalize WbTimes sent to Wikidata"

https://gerrit.wikimedia.org/r/934708

gerritbot added a project: Patch-For-Review.Jul 2 2023, 5:55 PM

I agree with Multichill, therefore I submitted his patch. The underlying problem of T325860 is described in T57755: it is currently not possible to enter time values more precise than 1 day on wikidata.org

Change 934708 merged by jenkins-bot: