Page MenuHomePhabricator
Create Task
Maniphest T340675

Stashbot should post multiple Phabricator links from a single IRC message in the order they were mentioned in the message
Closed, ResolvedPublicBUG REPORT
Actions

Description

This has been a minor annoyance to me for a long time. Today I had the following exchange with the bot that made a good example so I'm writing it up as a low priority bug.

[17:23]  <    bd808> I have been working on T339147 which then turned into working on T339307 and that may actually end with a partial solution for T195060
[17:23]  < stashbot> T339147: Release post-1.0.0 version - https://phabricator.wikimedia.org/T339147
[17:23]  < stashbot> T195060: Make rules and MessageValidator configurable - https://phabricator.wikimedia.org/T195060
[17:23]  < stashbot> T339307: Update commit-message-validator to work nicely with GitLab repos - https://phabricator.wikimedia.org/T339307

Ideally the bot would have followed the left-to-right ordering and emitted it's response as:

[17:23]  < stashbot> T339147: Release post-1.0.0 version - https://phabricator.wikimedia.org/T339147
[17:23]  < stashbot> T339307: Update commit-message-validator to work nicely with GitLab repos - https://phabricator.wikimedia.org/T339307
[17:23]  < stashbot> T195060: Make rules and MessageValidator configurable - https://phabricator.wikimedia.org/T195060

Details

SubjectRepoBranchLines +/-
Remove extra deduplication from bot.do_phabecholabs/tools/stashbotmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

bd808 created this task.Jun 28 2023, 5:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2023, 5:29 PM
bd808 triaged this task as Low priority.Jun 28 2023, 5:29 PM
bd808 added a comment.Sep 27 2023, 4:24 PM

I wonder if this is an unintended side effect of the use of set() in the python code to deduplicate the list of Phabricator objects? As far as I can tell the rest of the code in do_phabecho would inherently follow a left-to-right ordering. If that is the cause, I don't think the set() usage really does anything valuable for the algorithm. There is a deeper layer of notification deduplication within the processing loop that tracks "recent" links emitted so that we don't spam the channel with the same link over and over in a short period of time (5 minutes per config).

bd808 changed the task status from Open to In Progress.Sep 27 2023, 5:28 PM
bd808 claimed this task.
bd808 moved this task from Backlog to Accepted on the Stashbot board.
Restricted Application added a project: User-bd808. · View Herald TranscriptSep 27 2023, 5:28 PM
gerritbot added a comment.Sep 27 2023, 5:30 PM

Change 961432 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[labs/tools/stashbot@master] Remove extra deduplication from bot.do_phabecho

https://gerrit.wikimedia.org/r/961432

gerritbot added a project: Patch-For-Review.Sep 27 2023, 5:30 PM
gerritbot added a comment.Nov 9 2023, 11:35 PM

Change 961432 merged by jenkins-bot:

[labs/tools/stashbot@master] Remove extra deduplication from bot.do_phabecho

https://gerrit.wikimedia.org/r/961432

Maintenance_bot removed a project: Patch-For-Review.Nov 10 2023, 12:10 AM
bd808 mentioned this in rLTST0fc09b44cafd: Remove extra deduplication from bot.do_phabecho.Nov 10 2023, 12:38 AM
Stashbot mentioned this in T343157: Remove Twitter support.Nov 10 2023, 1:10 AM

Mentioned in SAL (#wikimedia-cloud) [2023-11-10T01:10:14Z] <wm-bot> <bd808> Updated to 5c3e0a8 and updated venv packages (T340675, T343157)

bd808 closed this task as Resolved.Nov 10 2023, 1:11 AM
[01:08]  <    bd808> I have been working on T339147 which then turned into working on T339307 and that may actually end with a partial solution for T195060
[01:08]  < stashbot> T339147: Release post-1.0.0 version - https://phabricator.wikimedia.org/T339147
[01:08]  < stashbot> T339307: Update commit-message-validator to work nicely with GitLab repos - https://phabricator.wikimedia.org/T339307
[01:08]  < stashbot> T195060: Make rules and MessageValidator configurable - https://phabricator.wikimedia.org/T195060
Aklapper awarded a token.Nov 10 2023, 9:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL