Several PHP 8.1 deprecation notices in DPLforum code
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Lakejason0
	Jul 4 2023, 3:01 AM

Description

Steps to replicate the issue

Uses MediaWiki 1.40.0
Go to a page uses DPLforum
See deprecation notices

What happens?:

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /www/wwwroot/podcast/extensions/DPLforum/src/DPLForum.php on line 254

Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /www/wwwroot/podcast/extensions/DPLforum/src/DPLForum.php on line 314

What should have happened instead?:
No deprecation notices

Software version (skip for WMF-hosted wikis like Wikipedia):
DPLforum: 3.7.2 (f890602)
MediaWiki: 1.40.0
PHP: 8.1.17

Details

	Subject	Repo	Branch	Lines +/-
	fix: fix null warning and drop use of wfGetDB	mediawiki/extensions/DPLforum	master	+21 -3

Customize query in gerrit

Related Objects

Mentioned Here: rEDPFf89060286fec: Localisation updates from https://translatewiki.net.

Event Timeline

Lakejason0 created this task.Jul 4 2023, 3:01 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 4 2023, 3:02 AM

Aklapper renamed this task from Several deprecation notices on DPLforum to Several PHP 8.1 deprecation notices in DPLforum code.Jul 4 2023, 9:33 AM

Aklapper added a project: PHP 8.1 support.

Reedy moved this task from Backlog to Other on the PHP 8.1 support board.Jul 7 2023, 5:03 PM

Lakejason0 added a comment.Fri, Jun 28, 10:43 AM

This comment was removed by Lakejason0.

Change #1050583 had a related patch set uploaded (by NekoCharm; author: NekoCharm):

[mediawiki/extensions/DPLforum@master] fix: fix null warning and drop use of wfGetDB

https://gerrit.wikimedia.org/r/1050583

gerritbot added a project: Patch-For-Review.Fri, Jun 28, 10:52 AM

Change #1050583 merged by jenkins-bot: