Page MenuHomePhabricator

Add ML team as developers to research repos
Closed, ResolvedPublic

Description

We would like the Machine Learning subgroup on gitlab to have edit access on research repos via the "Developer" permissions role.
This would allow us to open Merge Requests etc.

Event Timeline

KHernandez-WMF triaged this task as Medium priority.
KHernandez-WMF moved this task from Backlog to Staged on the Research board.

There is a 'Invite a group' button on the group members page https://gitlab.wikimedia.org/groups/repos/research/-/group_members, however list of groups that can be selected doesn't contain machine-learning. In fact, it seems the list of options is populated by an outdated structure (e.g. repos/{teamname} instead of groups/repos/{teamname}).

@brennen would you be able to advise how to enable the machine-learning group to contribute to research repos?

In fact, it seems the list of options is populated by an outdated structure (e.g. repos/{teamname} instead of groups/repos/{teamname})

Despite the existence of some URL paths containing groups/, there are no entities named groups/repos/{teamname}. So: /repos/machine-learning is the one you'd want. I've gone ahead and invited that group to repos/research.

(I think it's possible you were looking at the invite interface for the wrong group, because I just now made that mistake myself and spent several minutes trying to figure out what possible reason there could be for the machine learning group not showing up in the list.)

A caveat worth keeping in mind: T300939: GitLab group permissions are not inherited by sub-groups for groups of users invited to the parent repo probably means that things don't work as expected if you add any sub-groups. I'm pretty sure you'll have to invite the machine-learning group directly to new sub-groups if you want them to have the same access.

Also, this is minor, but remember that in theory groups don't strictly represent org-level teams as much as subject matter areas of code. In practice there's a lot of correspondence between team names and group names right now, but it's not in any way enforced and you can reasonably expect that it will drift over time because of organizational churn, scope creep, and the way that people accumulate hats around here.

(I apologize for GitLab UX being a trash fire.)