Page MenuHomePhabricator
Create Task
Maniphest T342234

Allow services to be injected into init
Closed, ResolvedPublic
Actions

Description

Implementation in termbox:

  • services: EntityRepository and WritingEntityRepository
  • Remove implementations of the above services

Details

SubjectRepoBranchLines +/-
REST: Fix error prone conditional statementsmediawiki/extensions/Wikibasemaster+47 -16
Remove code related to services that are now injectedwikibase/termboxmaster+17 -336
Make terms data access services configurable in client-entrywikibase/termboxmaster+65 -31
Turn FingerprintableEntity into an interfacewikibase/termboxmaster+38 -38
Improve client-entry.ts testabilitywikibase/termboxmaster+169 -122
Customize query in gerrit

Related Objects
Search...

Event Timeline

Silvan_WMDE created this task.Jul 19 2023, 12:15 PM
Silvan_WMDE mentioned this in T342235: Export type declarations alongside the termbox init function.Jul 19 2023, 12:18 PM
Jakob_WMDE mentioned this in T342243: Inject item/property specific data access services into Termbox from Wikibase.Jul 19 2023, 12:34 PM
Jakob_WMDE added a project: Wikibase Termbox UI: Prepare for Entity Schema UI.Jul 19 2023, 2:46 PM
Jakob_WMDE removed a project: Wikibase Termbox UI Exploration.Jul 19 2023, 3:06 PM
Jakob_WMDE claimed this task.Jul 20 2023, 2:22 PM
Jakob_WMDE moved this task from Backlog to Doing on the Wikibase Termbox UI: Prepare for Entity Schema UI board.
gerritbot added a comment.Jul 20 2023, 4:41 PM

Change 940200 had a related patch set uploaded (by Jakob; author: Jakob):

[wikibase/termbox@master] Improve client-entry.ts testability

https://gerrit.wikimedia.org/r/940200

gerritbot added a project: Patch-For-Review.Jul 20 2023, 4:41 PM
gerritbot added a comment.Jul 21 2023, 2:00 PM

Change 940200 merged by jenkins-bot:

[wikibase/termbox@master] Improve client-entry.ts testability

https://gerrit.wikimedia.org/r/940200

gerritbot added a comment.Jul 21 2023, 2:02 PM

Change 940358 had a related patch set uploaded (by Jakob; author: Jakob):

[wikibase/termbox@master] Make terms data services configurable in client-entry

https://gerrit.wikimedia.org/r/940358

Jakob_WMDE mentioned this in rWBTBa09c48bd4f64: Improve client-entry.ts testability.Jul 21 2023, 2:05 PM
gerritbot added a comment.Jul 21 2023, 4:38 PM

Change 940393 had a related patch set uploaded (by Jakob; author: Jakob):

[wikibase/termbox@master] Turn FingerprintableEntity into an interface

https://gerrit.wikimedia.org/r/940393

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Termbox UI: Prepare for Entity Schema UI board.Jul 24 2023, 8:27 AM
gerritbot added a comment.Jul 24 2023, 9:22 AM

Change 940874 had a related patch set uploaded (by Jakob; author: Jakob):

[wikibase/termbox@master] Remove code related to services that are now injected

https://gerrit.wikimedia.org/r/940874

gerritbot added a comment.Jul 24 2023, 3:18 PM

Change 940393 merged by jenkins-bot:

[wikibase/termbox@master] Turn FingerprintableEntity into an interface

https://gerrit.wikimedia.org/r/940393

gerritbot added a comment.Jul 24 2023, 3:19 PM

Change 940358 merged by jenkins-bot:

[wikibase/termbox@master] Make terms data access services configurable in client-entry

https://gerrit.wikimedia.org/r/940358

Jakob_WMDE mentioned this in rWBTBf58a391b736f: Turn FingerprintableEntity into an interface.Jul 24 2023, 3:42 PM
Jakob_WMDE mentioned this in rWBTBcd1d2b120222: Make terms data access services configurable in client-entry.
gerritbot added a comment.Jul 27 2023, 3:28 PM

Change 940874 merged by jenkins-bot:

[wikibase/termbox@master] Remove code related to services that are now injected

https://gerrit.wikimedia.org/r/940874

Maintenance_bot removed a project: Patch-For-Review.Jul 27 2023, 3:31 PM
Jakob_WMDE mentioned this in rWBTBe350ca884d36: Remove code related to services that are now injected.Jul 27 2023, 3:32 PM
Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Termbox UI: Prepare for Entity Schema UI board.Jul 27 2023, 3:34 PM
gerritbot added a comment.Aug 1 2023, 8:55 AM

Change 944162 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Fix error prone conditional statements

https://gerrit.wikimedia.org/r/944162

gerritbot added a project: Patch-For-Review.Aug 1 2023, 8:55 AM
gerritbot added a comment.Aug 1 2023, 8:58 AM

Change 944162 abandoned by Ollie Shotton:

[mediawiki/extensions/Wikibase@master] REST: Fix error prone conditional statements

Reason:

created by mistake

https://gerrit.wikimedia.org/r/944162

Maintenance_bot removed a project: Patch-For-Review.Aug 1 2023, 9:10 AM
Aklapper added a comment.Apr 2 2024, 3:58 AM

This open task has been in the "Done" column on the https://phabricator.wikimedia.org/tag/wikibase_termbox_ui_prepare_for_entity_schema_ui/ workboard for a long time. Is there any reason why its status is not changed to "Resolved"? (Please close tasks so they do not show up in queries for open unresolved tasks - thanks.)

Ifrahkhanyaree_WMDE closed this task as Resolved.Apr 2 2024, 7:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits