Page MenuHomePhabricator
Create Task
Maniphest T343075

FilterRunner shouldn't add any more variables
Open, Needs TriagePublic
Actions

Description

Currently, FilterRunner depends on VariableGenerator(Factory) to amend the provided VariableHolder with generic variables. The responsibility for initializing variables already lies on the callers for most variables already. Let's make it consistent and remove this dependency.

This isn't backward compatible and requires prior updates in other extensions.

Details

SubjectRepoBranchLines +/-
Call VariableGenerator::addGenericVars explicitlymediawiki/extensions/Flowmaster+1 -0
Call VariableGenerator::addGenericVars explicitlymediawiki/extensions/ArticleFeedbackv5master+8 -4
Call VariableGenerator::addGenericVars explicitlymediawiki/extensions/Commentsmaster+4 -1
Customize query in gerrit

Event Timeline

matej_suchanek created this task.Jul 29 2023, 2:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2023, 2:32 PM
gerritbot added a comment.Jul 29 2023, 2:33 PM

Change 808371 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/AbuseFilter@master] Set all variables in the generator, not the runner

https://gerrit.wikimedia.org/r/808371

gerritbot added a project: Patch-For-Review.Jul 29 2023, 2:33 PM

Change 932673 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/Flow@master] Call VariableGenerator::addGenericVars explicitly

https://gerrit.wikimedia.org/r/932673

gerritbot added a comment.Jul 29 2023, 2:33 PM

Change 933407 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/Comments@master] Call VariableGenerator::addGenericVars explicitly

https://gerrit.wikimedia.org/r/933407

gerritbot added a comment.Jul 29 2023, 2:33 PM

Change 933406 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/ArticleFeedbackv5@master] Call VariableGenerator::addGenericVars explicitly

https://gerrit.wikimedia.org/r/933406

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL