dumpBackup.php exception: TypeError: XmlDumpWriter::canonicalTitle(): Argument #1 ($title) must be of type Title, null given
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	FrozenPlum
	Jul 30 2023, 7:04 PM

Description

MediaWiki	1.39.4
PHP	8.0.28 (cgi-fcgi)
MySQL	8.0.28-0ubuntu0.20.04.3
CommentStreams	8.0-dev (6b3a3ed)

When doing dumpBackup.php with CommentStreams enabled, I get the exception:

2023-07-30 18:56:12 vps###### my_site_: [7bb73dbe9364462616363b12] [no req]   TypeError: XmlDumpWriter::canonicalTitle(): Argument #1 ($title) must be of type Title, null given, called in /home/my_user/mysite.com/w/extensions/CommentStreams/includes/MainHooks.php on line 417
#0 /home/my_user/mysite.com/w/extensions/CommentStreams/includes/MainHooks.php(417): XmlDumpWriter::canonicalTitle(NULL)
#1 /home/my_user/mysite.com/w/includes/HookContainer/HookContainer.php(160): MediaWiki\Extension\CommentStreams\MainHooks->onXmlDumpWriterOpenPage(XmlDumpWriter, string, stdClass, Title)
#2 /home/my_user/mysite.com/w/includes/HookContainer/HookRunner.php(4518): MediaWiki\HookContainer\HookContainer->run(string, array)
#3 /home/my_user/mysite.com/w/includes/export/XmlDumpWriter.php(267): MediaWiki\HookContainer\HookRunner->onXmlDumpWriterOpenPage(XmlDumpWriter, string, stdClass, Title)
#4 /home/my_user/mysite.com/w/includes/export/WikiExporter.php(551): XmlDumpWriter->openPage(stdClass)
#5 /home/my_user/mysite.com/w/includes/export/WikiExporter.php(493): WikiExporter->outputPageStreamBatch(Wikimedia\Rdbms\MysqliResultWrapper, stdClass)
#6 /home/my_user/mysite.com/w/includes/export/WikiExporter.php(315): WikiExporter->dumpPages(string, boolean)
#7 /home/my_user/mysite.com/w/includes/export/WikiExporter.php(175): WikiExporter->dumpFrom(string)
#8 /home/my_user/mysite.com/w/maintenance/includes/BackupDumper.php(363): WikiExporter->allPages()
#9 /home/my_user/mysite.com/w/maintenance/dumpBackup.php(82): BackupDumper->dump(integer, integer)
#10 /home/my_user/mysite.com/w/maintenance/includes/MaintenanceRunner.php(309): DumpBackup->execute()
#11 /home/my_user/mysite.com/w/maintenance/doMaintenance.php(85): MediaWiki\Maintenance\MaintenanceRunner->run()
#12 /home/my_user/mysite.com/w/maintenance/dumpBackup.php(144): require_once(string)
#13 {main}

Details

	Subject	Repo	Branch	Lines +/-
	Fix error dumping page with comments	mediawiki/extensions/CommentStreams	master	+11 -9

Customize query in gerrit

Related Objects

Mentioned In: rECOS18cc37b0d7c6: Fix error dumping page with comments
Mentioned Here: rECOS6b3a3ed34180: Localisation updates from https://translatewiki.net.

Event Timeline

FrozenPlum created this task.Jul 30 2023, 7:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2023, 7:04 PM

Aklapper renamed this task from dumpBackup.php exception to dumpBackup.php exception: TypeError: XmlDumpWriter::canonicalTitle(): Argument #1 ($title) must be of type Title, null given.Jul 30 2023, 8:16 PM

CCicalese_WMF moved this task from Backlog to In Progress on the MediaWiki-extensions-CommentStreams board.Aug 10 2023, 5:01 PM

Change 947936 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/CommentStreams@master] Fix error dumping page with comments

https://gerrit.wikimedia.org/r/947936

gerritbot added a project: Patch-For-Review.Aug 10 2023, 8:07 PM

Thank you for reporting this error. I was not able to reproduce it locally, but I put a bit more error checking that should catch it. Could you please test the patch to see if it takes care of the error for you? Thank you.

cicalese triaged this task as High priority.Aug 10 2023, 8:35 PM

cicalese moved this task from In Progress to Waiting for Merge on the MediaWiki-extensions-CommentStreams board.Aug 11 2023, 2:44 AM

cicalese changed the subtype of this task from "Task" to "Bug Report".Aug 11 2023, 2:48 AM

Change 947936 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@master] Fix error dumping page with comments

https://gerrit.wikimedia.org/r/947936

cicalese mentioned this in rECOS18cc37b0d7c6: Fix error dumping page with comments.Sep 4 2023, 8:43 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2023, 9:10 PM

cicalese closed this task as Resolved.Sep 5 2023, 2:27 AM

cicalese claimed this task.

cicalese moved this task from Waiting for Merge to Closed on the MediaWiki-extensions-CommentStreams board.

cicalese merged a task: T349659: dumpBackup.php Argument #1 ($title) must be of type Title, null given.Oct 27 2023, 5:03 PM

dumpBackup.php exception: TypeError: XmlDumpWriter::canonicalTitle(): Argument #1 ($title) must be of type Title, null givenClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

dumpBackup.php exception: TypeError: XmlDumpWriter::canonicalTitle(): Argument #1 ($title) must be of type Title, null given
Closed, ResolvedPublicBUG REPORT
Actions