Page MenuHomePhabricator
Create Task
Maniphest T343441

Pass StatementGuid instead of EntityId into the Statement Subject Revision Metadata classes
Closed, ResolvedPublic
Actions

Description

Pass StatementGuid instead of EntityId objects into the following:

  • AssertStatementSubjectExists::execute() use case step
  • GetLatestStatementSubjectRevisionMetadata::execute() use case step
  • StatementSubjectRevisionMetaDataRetriever::getLatestRevisionMetadata() interface and implementation

Requires T343442: 🍫️ Create subject specific statement use case wrappers to be completed first.

Details

SubjectRepoBranchLines +/-
REST: Use StatementId instead of EntityId for metadata retrieversmediawiki/extensions/Wikibasemaster+57 -53
REST: Remove STATEMENT_SUBJECT_NOT_FOUNDmediawiki/extensions/Wikibasemaster+12 -41
Customize query in gerrit

Related Objects

Event Timeline

Ollie.Shotton_WMDE created this task.Aug 3 2023, 12:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2023, 12:16 PM
Ollie.Shotton_WMDE mentioned this in T343442: 🍫️ Create subject specific statement use case wrappers.Aug 3 2023, 12:19 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)
gerritbot added a comment.Aug 3 2023, 12:23 PM

Change 945590 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Use StatementGuid instead of EntityId for metadata retrievers

https://gerrit.wikimedia.org/r/945590

gerritbot added a project: Patch-For-Review.Aug 3 2023, 12:23 PM
Ollie.Shotton_WMDE claimed this task.Aug 25 2023, 1:47 PM
Ollie.Shotton_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 2 ); removed Wikibase Product Platform Team WPP.
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 2 ) board.
Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 2 ) board.Aug 25 2023, 2:02 PM
gerritbot added a comment.Aug 25 2023, 3:12 PM

Change 952466 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove STATEMENT_SUBJECT_NOT_FOUND

https://gerrit.wikimedia.org/r/952466

gerritbot added a comment.Aug 28 2023, 8:23 AM

Change 945590 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use StatementId instead of EntityId for metadata retrievers

https://gerrit.wikimedia.org/r/945590

gerritbot added a comment.Aug 28 2023, 8:23 AM

Change 952466 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove STATEMENT_SUBJECT_NOT_FOUND

https://gerrit.wikimedia.org/r/952466

Maintenance_bot removed a project: Patch-For-Review.Aug 28 2023, 8:29 AM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 2 ) board.Aug 28 2023, 8:39 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 4:01 AM
Ifrahkhanyaree_WMDE closed this task as Resolved.Sep 11 2023, 10:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL