Page MenuHomePhabricator

SemanticForms r102365 breaks red link on Special:Search
Closed, ResolvedPublic

Description

Author: van.de.bugger

Description:
Commit r102365 "strict comparators for empty strings" breaks Special::Search.

How to reproduce:

$ svn update -r 102107 # it is a previous version of SF before 102365

then go to Special:Search, type any garbage in the input field, press Search button. I suppose, the page is not found, so message

The page "Garbage" does not exist.

"Garbage" is a red link with href=".../index.php?title=Garbage&action=edit&redlink=1", so following the link will create the page.

Then

$ svn update -r 102365

Do the same. "Garbage" is a red link, but href="" (empty), so following the link returns to the same Search page.

I do not now how SemanticForms affects SearchPage, but updating SemanticForms sources back to r102107 fixes the issue. Disabling SemanticForms also helps to get red links on Special:Search working. All the revisions after r102365 also affected.


Version: unspecified
Severity: critical

Details

Reference
bz32345

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:00 AM
bzimport set Reference to bz32345.

Hi,

Thanks for reporting, and diagnosing, that problem. It was indeed in that revision, and I think I just fixed it in SVN.

van.de.bugger wrote:

Verified on r102853.