Page MenuHomePhabricator

Wikieditor toolbar has only a half of screen width
Closed, ResolvedPublic


Author: beau

Patch fixing the reported issue

When editing Page namespace the width of the toolbar is limited by Proofread extension, which wraps the editing area before toolbar is constructed. Proofread extension should be run after toolbar is ready.

Version: unspecified
Severity: enhancement




Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:01 AM
bzimport added a project: ProofreadPage.
bzimport set Reference to bz32372.

beau wrote:

Screenshot of current version


before.png (239×785 px, 57 KB)

beau wrote:

Screenshot of a new version


after.png (246×839 px, 20 KB)

zaran.krleza wrote:

What about users using horizontal mode (when the image is over the edit box). Should the toolbar be over the image or between the image and the edit box?

beau wrote:

I think it should be between the image and the edit box, so proofread+my patch works like that right now.

beau wrote:

I have submitted change I34fc8565383cde80be70211b97acd09c2ca923d5 for review.

Please, when will this be deployed? This is a very useful enhancement, and according to Beau it also fixes bug 36229 which is presently blocking some users completely.

sumanah wrote:

Candalua, I've asked several people for help in reviewing this revision -- hope that helps.

beau wrote:

The change has been merged.