Page MenuHomePhabricator

re-enable `"responsive": true,` in Vector legacy OR honor `$wgVectorResponsive = true;`
Open, Needs TriagePublicBUG REPORT

Description

https://github.com/wikimedia/mediawiki-skins-Vector/commit/155bb9a4daa6d9d4132d0a4a7d56f45cc49c92b7
broke mobile support for our self-hosted mediawiki when updating form 1.39.4 to 1.40.0.

This is because isResponsive depends on the skin being "responsive capable"
https://phabricator.wikimedia.org/source/mediawiki/browse/REL1_40/includes/skins/Skin.php$308-314

We made Vector Legacy "responsive capable" by using our own scripts as "augmentations". And to avoid workarounds we would like to have either Vector legacy set back to responsive: true or have option $wgVectorResponsive = true; honored for Vector Legacy.

For now we have to patch it in the source file. like this

str_replace '"responsive": false,' '"responsive": true,' /var/www/wiki/w/skins/Vector/skin.json

If,

  • no user reported a bug about "responsive": true, in Vector Legacy,
  • you didn't experience any issues from that,
  • if the behavior gets worse and not better for anyone,

could the above referenced git commits be reverted please?