Page MenuHomePhabricator

Special:ChangeContentModel: two form fields containing "content model" is confusing
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
Novem_Linguae
Aug 18 2023, 2:31 PM
Referenced Files
F41464464: image.png
Nov 7 2023, 8:16 AM
F41464455: image.png
Nov 7 2023, 8:15 AM
F37569536: image.png
Aug 18 2023, 2:31 PM
F37569530: image.png
Aug 18 2023, 2:31 PM

Description

Steps to replicate the issue (include links if applicable):

What happens?:

image.png (119×315 px, 5 KB)

What should have happened instead?:

image.png (133×285 px, 2 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • It violates the principle of least astonishment and is confusing for Sanitized CSS to be selected as the new content model by default. I suggest adding a blank option, then throwing a form validation error if that remains selected.
  • Confusingly, in ooui, when text boxes are editable they are white, and when they are not editable (readonly) they are gray. But when combo boxes are editable they are gray, and when they are not editable (readonly) they are gray. Special:ChangeContentModel uses a mix of readonly and editable, with lots of gray, and gray not corresponding to readonly or editable consistently. Since changing the ooui combo box background color doesn't seem likely to me to get merged, I think this approach of adding a blank combo box option helps solve that confusion.

image.png (1×1 px, 88 KB)

Event Timeline

Change 972316 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/core@master] Special:ChangeContentModel should default to a blank model

https://gerrit.wikimedia.org/r/972316

Change 972316 merged by jenkins-bot:

[mediawiki/core@master] Combine two drop-down lists into one in Special:ChangeContentModel

https://gerrit.wikimedia.org/r/972316

Novem_Linguae renamed this task from Special:ChangeContentModel "new content model" should default to blank instead of Sanitized CSS to Special:ChangeContentModel: two form fields containing "content model" is confusing.Wed, Nov 22, 11:56 AM
Novem_Linguae closed this task as Resolved.
Novem_Linguae claimed this task.