Hardcoded string in AbstractCheckUserPager::getTimeRangeString
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Sep 4 2023, 4:44 PM

Description

The method AbstractCheckUserPager::getTimeRangeString uses a hardcoded string to define the separator between two timestamps. This should be a message definition so that the timestamps can be reversed or otherwise the separator modified to be correct for a given language.

Relevant code is at AbstractCheckUserPager line 126.

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T345586#9150646

Details

	Subject	Repo	Branch	Lines +/-
	Use i18n message in AbstractCheckUserPager::getTimeRangeString	mediawiki/extensions/CheckUser	master	+67 -6

Customize query in gerrit

Related Objects

Mentioned Here: rECHU7402d9975fb3: Merge "ipReveal.js: Don't pass limit param to revisions and logs APIs"
rMW2f2802eb7526: Merge "rdbms: Small clean ups to query builders"

Event Timeline

Dreamy_Jazz created this task.Sep 4 2023, 4:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2023, 4:44 PM

Dreamy_Jazz moved this task from General / Unsorted to CheckUser on the CheckUser board.Sep 4 2023, 4:44 PM

Dreamy_Jazz moved this task from Untriaged to Untranslatable strings on the I18n board.

Dreamy_Jazz renamed this task from Hardcoded string in `AbstractCheckUserPager::getTimeRangeString` to Hardcoded string in AbstractCheckUserPager::getTimeRangeString.Sep 4 2023, 4:47 PM

Dreamy_Jazz updated the task description. (Show Details)

Change 954729 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use i18n message in AbstractCheckUserPager::getTimeRangeString

https://gerrit.wikimedia.org/r/954729

gerritbot added a project: Patch-For-Review.Sep 4 2023, 5:05 PM

Dreamy_Jazz added a project: Anti-Harassment (AHaT Sprint 32 - Baseball Cap).Sep 4 2023, 6:39 PM

Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

Dreamy_Jazz claimed this task.Sep 4 2023, 9:25 PM

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Sep 7 2023, 2:22 PM

Change 954729 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use i18n message in AbstractCheckUserPager::getTimeRangeString

https://gerrit.wikimedia.org/r/954729

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 7 2023, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 7 2023, 3:10 PM

As this patch should make no visual change to the output, I would suggest that QA does the following:

Log into an account
Ensure the account uses the language "English - en" (this can be checked in the 'User profile' tab of Special:Preferences)
Make one action logged by CheckUser on an IP that hasn't been used before on the wiki
Make multiple actions logged by CheckUser on another IP
Checkout a branch that does not have this change
Load Special:CheckUser
Enter your account name and choose the 'Get IP addresses' mode (should be selected by default)
Run a check
Check that the first IP has one timestamp and the second IP has a timestamp range
Checkout the latest master branch (that has this change)
Run the check again and make sure that nothing visually changed with regards to the timestamps.

@Dreamy_Jazz There was nothing visually changed with regard to the timestamps between the old branch and the current master as seen in the screenshots. The first IP has one timestamp and the second IP has a timestamp range. I will move this to Done. Thanks for all your work!

Status: ✅ PASS
Environment: Local 1.41.0-alpha (2f2802e) 20:03, 11 September 2023. CheckUser: 2.5 (7402d99) 13:46, 11 September 2023
OS: macOS Ventura
Browser: Chrome 116
Device: MBP
Emulated Device:: N/A
Test Links:
http://localhost:8080/w/index.php?title=Philadelphia_Eagles

✅AC1: https://phabricator.wikimedia.org/T345586#9150646

Branch w/ no change	Master

Dreamy_Jazz closed this task as Resolved.Oct 20 2023, 3:14 PM

Hardcoded string in AbstractCheckUserPager::getTimeRangeStringClosed, ResolvedPublicActions