Page MenuHomePhabricator

Previewing appears to have submitted
Closed, ResolvedPublic

Description

Author: wiki+bugzilla

Description:
Previewing edits seems to have somehow actually SUBMITTED them:

07:42, 2005 Feb 3 (hist) (diff) User:J'raxis (Added "missing" notice, Arabic

form.) (top)

07:40, 2005 Feb 3 (hist) (diff) User:J'raxis (Added "missing" notice, Arabic

form.)

07:39, 2005 Feb 3 (hist) (diff) User:J'raxis (Added "missing" notice, Arabic

form.)

07:37, 2005 Feb 3 (hist) (diff) User:J'raxis (Added "missing" notice, Arabic

form.)

07:36, 2005 Feb 3 (hist) (diff) User:J'raxis (Added "missing" notice, Arabic

form.)

  1. 07:36, 2005 Feb 3 (hist) (diff) User:J'raxis
  2. 07:35, 2005 Feb 3 (hist) (diff) User:J'raxis (Added "missing" notice, Arabic

form.)

Each of these other than the topmost was caused by me previewing. I believe I
previewed it more times than what you see here, so preview isn't ALWAYS causing
an actual submit. I'm not sure if this is reproduceable, as I don't want to make
a mess of any page histories trying to reproduce it.

[This is NOT a duplicate of bug 1263, which I submitted some time ago, about
dupe entries showing up in page histories, although it may be related: the
server was being extremely slow while I was previewing.]

Additionally, is there any way this edit history can be cleaned up? Ironically,
I was in the process of adding a note to my user page about why I've disappeared
from Wikipedia recently: because of the difficulty in editing anything without
the server being impossibly slow, logging me out in the middle of an edit thus
not attributing the edit to me, or creating dupe entries. Now with this
ridiculous-looking mess made of my user history, if it can't be fixed, I'm
thinking of calling it quits completely.


Version: unspecified
Severity: normal
OS: Linux
Platform: PC
URL: http://en.wikipedia.org/w/index.php?title=Special:Contributions&target=J%27raxis

Details

Reference
bz1458
TitleReferenceAuthorSource BranchDest Branch
requirements: version bump eventutilities.repos/data-engineering/mediawiki-event-enrichment!77gmodenaversion-bump-eventutilitiesmain
make: version bump mediawiki-event-utilities.repos/data-engineering/eventutilities-python!84gmodenamediawiki-event-utilities-version-bumpmain
requirements: version bump eventutilites-python.repos/data-engineering/mediawiki-event-enrichment!73gmodenaeventutilites-python-version-bumpmain
eventutiliites: version bump to 1.3.0.repos/data-engineering/eventutilities-python!81gmodenaeventutilities-version-bumpmain
Update analytics mw history check and reduced jobsrepos/data-engineering/airflow-dags!488joalupdate_analytics_mediawiki_history_check_jobmain
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:10 PM
bzimport set Reference to bz1458.
bzimport added a subscriber: Unknown Object (MLST).

Could be a problem with post data being cut off partway through, missing the submission info that indicates
it's a preview. That's consistent with for instance this diff:
http://en.wikipedia.org/w/index.php?title=User:J%27raxis&diff=9907156&oldid=9907152

Will take a look...

wiki+bugzilla wrote:

Yeah, that's probably it. I think I hit stop a few times during the previews
because it was being so slow. Perhaps not having wpSave as the default action
would be a good idea in a future version of MediaWiki. wpSave as default also
has the mildly irritating effect of causing a premature submit if one
accidentally hits enter in the summary box, something I've also done a few times.

[Mildly OT, but where do I ask about having a Sysop cleanup this revision
history? Last time I had a request like this, I eventually found some help pages
at either Wikipedia proper or the Meta site that said to email a Sysop who has
DB write access, but I never got responses from those whom I emailed.]

I've made a fix to force preview mode if the form submission is incomplete (indicated by wpEdittime, the very
last field on the form, not being set). I believe this should be sufficient to prevent saves on partial form
submissions.

When the submission is complete, save needs to be implicitly assumed when neither wpSave nor wpPreview is
present in order to allow saving by hitting enter from the summary box or checkboxes. (This is intentional, as
every other form submission on the web works like that.)

I'll clean up those stray entries from the database shortly...

zigger wrote:

*** Bug 610 has been marked as a duplicate of this bug. ***

Have removed the reported bogus intermediate revisions from 7:35 through 7:40.

richholton wrote:

I wonder if this bug could be related to #275: Page or section content
duplication on edit conflict with self.