Currently failing on master, e.g.
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/124625/console
ThreadItemStoreTest::testInsertThreadItems is a large integration test for the DiscussionTools permalinks feature (sorry about that), covering everything from creating page revisions to saving the metadata generated from these revisions, and it fails because some of the expected metadata is missing.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update expected IDs in ThreadItemStore tests | mediawiki/extensions/DiscussionTools | master | +186 -186 |
I think this is because MediaWiki no longer inserts a "default" user/page/revision into the database before running our tests (since rMWf83e611efa69: Make MediaWikiIntegrationTestCase::addCoreDBData a noop), so various IDs are off-by-one, and should simply be updated.
However, locally I still see those default items (and no test failures), and I can't figure out what's inserting them.
Change 956073 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Update expected IDs in ThreadItemStore tests
Change 956073 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Update expected IDs in ThreadItemStore tests