Page MenuHomePhabricator

CheckUser Phan currently fails on master
Closed, ResolvedPublic

Description

CheckUser CI currently fails on the master branch due to the merging of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/914744.

The fix is to make AbstractCheckUserPager::getIpConds take a IReadableDatabase. Work to make the method instead take a DBQuoter is being done in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/954051 but that isn't merged yet and is a big change to review just for this build failure.

Event Timeline

Dreamy_Jazz triaged this task as High priority.EditedSep 12 2023, 8:09 PM
Dreamy_Jazz updated the task description. (Show Details)

Doesn't seem to be directly blocking the train except for changes for the CheckUser extension. It also doesn't seem to break the API. Therefore, marking as High priority.

Change 956958 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Change AbstractCheckUserPager::getIpConds to use IReadableDatabase

https://gerrit.wikimedia.org/r/956958

Change 956958 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Change AbstractCheckUserPager::getIpConds to use IReadableDatabase

https://gerrit.wikimedia.org/r/956958

Dreamy_Jazz closed this task as Resolved.EditedSep 12 2023, 9:38 PM

This shouldn't need QA as this just resolved CI issues, so I'm going to move this to Done and resolve it. Plus, resolving this now means that the it doesn't remain open in the ci-test-error (WMF-deployed Build Failure) column.