DiscussionTools CI tests are failing due to a test written in the CheckUser extension failing. Examples:
- https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/125833/console
- https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/125653/console
The failing test compares the HTML output to HTML output generated in the data provider. This comparison aims to check that the CheckUser extension generates the correct action text (and it's HTML) when displaying a log entry. However, the URL that is used in the link is different between the data provider and the one generated in the code under test. Both are generated by a call to LogFormatter::getActionText which should return the same HTML and does when running CI for CheckUser. However, this seems to be an incorrect assumption for the DiscussionTools repository.
The HTML differs in the URL structure of the link and therefore I suspect that the DiscussionTools extension / it's tests have a modified URL structure such that the tests run fine for the CheckUser extension but fail when on the DiscussionTools extension due to the order in which they are run. The fix for this should be easily done by generating the expected HTML in the actual test and not the data provider, such that the change in URL structure applies to the expected and actual action text.