result type mismatch of redirect method in BaseSite and ApiSite
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Sep 23 2023, 2:04 PM

Description

There is a type mismatch of BaseSite.redirect() returning a list and ApiSite.redirect() returning a string.

Usually BaseSite isn't used directly. Therefore I propose to fix the BaseSite side to return a single string with BaseSite.redirect().
The change was made for BaseSite in https://static-codereview.wikimedia.org/pywikipedia/7989.html

	Subject	Repo	Branch	Lines +/-
	[cleanup] cleanup redirect methods	pywikibot/core	master	+41 -46

Xqt changed the task status from Open to In Progress.Sep 23 2023, 2:04 PM

Xqt claimed this task.

Xqt triaged this task as Low priority.

Change 960172 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [cleanup] cleanup redirect methods

Xqt closed this task as Resolved.Sep 29 2023, 1:26 PM

Change 960172 merged by jenkins-bot:

[pywikibot/core@master] [cleanup] cleanup redirect methods