Page MenuHomePhabricator

Issues with tabs on AFT v5 Feedback Form Option 2
Closed, ResolvedPublic

Description

We have a number of issues related to the tabs in AFT v5 Feedback Form Option 2:

  • Let's use a larger font for the tab labels (Suggestion, Question, Problem and Praise), increasing them by by a couple points, to about 1.3 em or 15 points (see new mockup).
  • The four tabs should be more spaced out apart from each other, rather than being all squished together on the left (see new mockup).
  • The first tab should be selected by default ('Suggestion'), with a cartoon bubble around it. (the other tabs are unselected, without any border around them)
  • When you hover over the tabs, the pointy arrow below the cartoon bubble should appear below as it does when you select that tab.
  • Use a black outline (instead of a gray outline) for the cartoon bubble around the selected tab (e.g.: 'Suggestion'), just as we do around the text box.

If needed, feel free to break up this bug into separate bugs


Version: unspecified
Severity: normal
URL: http://prototype.wikimedia.org/release-en/Test_table?bucket=2

Details

Reference
bz32842

Related Objects

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:03 AM
bzimport set Reference to bz32842.

yoni wrote:

Fixed: ** The first tab should be selected by default ('Suggestion'), with a cartoon
bubble around it. (the other tabs are unselected, without any border around
them)

Reassigning to Sean for visual fixes.

sheavey wrote:

  • Let's use a larger font for the tab labels (Suggestion, Question, Problem

and Praise), increasing them by by a couple points, to about 1.3 em or 15
points (see new mockup).
Sean: Font size is now 1.3em on OmniTi Dev

  • The four tabs should be more spaced out apart from each other, rather than

being all squished together on the left (see new mockup).
Sean: Spacing has been doubled on OmniTi Dev

  • The first tab should be selected by default ('Suggestion'), with a cartoon

bubble around it. (the other tabs are unselected, without any border around
them)
Sean: This is implemented on OmniTi Dev

  • When you hover over the tabs, the pointy arrow below the cartoon bubble

should appear below as it does when you select that tab.
Sean: This will create a useability conflict. I will create a seperate bug for this one while we discuss.

  • Use a black outline (instead of a gray outline) for the cartoon bubble

around the selected tab (e.g.: 'Suggestion'), just as we do around the text
box.
Sean: Outline is now black.