Page MenuHomePhabricator
Create Task
Maniphest T348890

docs: Fix broken Dialog demo
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Description

The reusable custom Dialog example has a broken demo in the docs. We can resolve this issue by removing the vertical whitespace within the cdx-demo-wrapper.

Screenshot of broken demo in Dialog:

Screenshot 2023-10-13 at 12.42.12 PM.png (2,690×1,754 px, 536 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update Codex from v1.0.0-rc.1 to v1.0.0Jforrestermediawiki/coreREL1_41+9 K -14
Update Codex from v1.0.0-rc.1 to v1.0.0Anne Tomasevichmediawiki/coremaster+9 K -13
docs: Fix broken Dialog demoLWatsondesign/codexmain+0 -1
Customize query in gerrit

Event Timeline

lwatson created this task.Oct 13 2023, 5:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2023, 5:53 PM
gerritbot added a comment.Oct 13 2023, 6:36 PM

Change 965791 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] docs: Fix broken Dialog demo

https://gerrit.wikimedia.org/r/965791

gerritbot added a project: Patch-For-Review.Oct 13 2023, 6:36 PM
lwatson changed the task status from Open to In Progress.Oct 13 2023, 6:40 PM
lwatson moved this task from Inbox to Design-Systems-Sprint-10 on the Design-System-Team board.
lwatson edited projects, added: Design-System-Team (Design-Systems-Sprint-10); removed: Design-System-Team.
lwatson set the point value for this task to 1.
lwatson moved this task from Committed to Code Review on the Design-System-Team (Design-Systems-Sprint-10) board.
AnneT moved this task from Code Review to Pending Release on the Design-System-Team (Design-Systems-Sprint-10) board.Oct 16 2023, 1:06 PM
gerritbot added a comment.Oct 16 2023, 1:19 PM

Change 965791 merged by jenkins-bot:

[design/codex@main] docs: Fix broken Dialog demo

https://gerrit.wikimedia.org/r/965791

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2023, 1:29 PM
gerritbot added a comment.Oct 24 2023, 7:27 PM

Change 968345 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v1.0.0-rc.1 to v1.0.0

https://gerrit.wikimedia.org/r/968345

gerritbot added a project: Patch-For-Review.Oct 24 2023, 7:27 PM
PatchDemoBot added a comment.Oct 24 2023, 7:30 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/b8a4f83606/w

gerritbot added a comment.Oct 24 2023, 8:02 PM

Change 968345 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.0.0-rc.1 to v1.0.0

https://gerrit.wikimedia.org/r/968345

Maintenance_bot removed a project: Patch-For-Review.Oct 24 2023, 8:10 PM
gerritbot added a comment.Oct 24 2023, 10:46 PM

Change 968370 had a related patch set uploaded (by Jforrester; author: Anne Tomasevich):

[mediawiki/core@REL1_41] Update Codex from v1.0.0-rc.1 to v1.0.0

https://gerrit.wikimedia.org/r/968370

gerritbot added a project: Patch-For-Review.Oct 24 2023, 10:46 PM
gerritbot added a comment.Oct 24 2023, 11:08 PM

Change 968370 merged by jenkins-bot:

[mediawiki/core@REL1_41] Update Codex from v1.0.0-rc.1 to v1.0.0

https://gerrit.wikimedia.org/r/968370

Maintenance_bot removed a project: Patch-For-Review.Oct 24 2023, 11:10 PM
AnneT closed this task as Resolved.Oct 25 2023, 3:30 PM
AnneT claimed this task.
PatchDemoBot added a comment.Apr 23 2024, 3:51 PM

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/b8a4f83606/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits