Page MenuHomePhabricator
Create Task
Maniphest T348906

Who Wrote That has stopped working after specific revision (due to local User:Lingzhi2/reviewsourcecheck-sb.js)
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • It works for the first page (1179715699).
  • It does not for the second (1179716363); hovering or clicking on text anywhere in the article has no effect
  • It also does not work for any subsequent revisions.

The diff between those two shows nothing remarkable.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • Chrome Version 118.0.5993.70 (Official Build) (x86_64)
  • MacOS 12.6.1 (21G217)

Event Timeline

RoySmith created this task.Oct 14 2023, 2:39 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptOct 14 2023, 2:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
TheresNoTime edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.Oct 15 2023, 11:56 AM
TheresNoTime subscribed.

(not yet looked closer, but was there any console errors?)

TheresNoTime added a comment.Oct 15 2023, 12:03 PM

Hm, having now tried to replicate, it seems it might be working again — can you confirm @RoySmith?

rev 1179716363

Screenshot 2023-10-15 at 13.01.51.png (826×1 px, 247 KB)

RoySmith added a comment.Oct 15 2023, 4:39 PM

Interesting. I can still reproduce it here. I normally use Chrome, but just tried this in Firefox 109.0.1 (64-bit) and can reproduce it there as well. I'm not seeing anything exciting in the console:

contentScript.js:10 Who Wrote That? (Browser extension): Loaded on page.
contentScript.js:10 Who Wrote That? (Browser extension): Checking WelcomeTourSeen (true)
load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:12 This page is using the deprecated ResourceLoader module "jquery.ui".
Please use OOUI instead.
execute @ load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:12
load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:12 This page is using the deprecated ResourceLoader module "mediawiki.ui.button".
[1.41] Please use Codex. See migration guidelines: https://w.wiki/7TAh
execute @ load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:12
load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:12 This page is using the deprecated ResourceLoader module "mediawiki.ui.checkbox".
[1.41] Please use Codex. See migration guidelines: https://w.wiki/7TAh
execute @ load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:12
 ?title=Fleetwood_Park_Racetrack&oldid=1179716363
load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:12 This page is using the deprecated ResourceLoader module "mediawiki.ui.input".
[1.41] Please use Codex. See migration guidelines: https://w.wiki/7TAh
execute @ load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:12
index.php?title=user:theleekycauldron/DYK_promoter.js&action=raw&ctype=text/javascript:16 ready!
7The resource <URL> was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.
Frostly subscribed.Oct 15 2023, 5:02 PM
Isochrone subscribed.Oct 15 2023, 5:31 PM

Can't replicate on Firefox 119/Windows 11
On rev 1179715699

1.png (586×961 px, 87 KB)

On rev 1179716363
2.png (586×966 px, 88 KB)

(highlighting is a New Vector issue)

Isochrone added a comment.Oct 15 2023, 5:43 PM

Hi @RoySmith, could you try removing User:Lingzhi2/reviewsourcecheck-sb.js from your common.js and seeing if the issue still occurs? That seemed to break it for me.

RoySmith added a comment.Oct 15 2023, 6:00 PM

Wow, yeah, that fixed it, thanks.

I think there may also be something non-deterministic going on. As I've been doing this repeatedly, I'm pretty sure I saw one time when WhoWroteThat worked on both revisions (and before I disabled reviewsourcecheck). I'm not 100% sure about that, however. I'll drop a note to User:Lingzhi2.

TheresNoTime closed this task as Resolved.Oct 15 2023, 7:22 PM
TheresNoTime claimed this task.

Closing as it appears to be an interaction with User:Lingzhi2/reviewsourcecheck-sb.js as mentioned above — if there's anything we need to do/can do to help, please feel free to reopen :)

Aklapper renamed this task from Who Wrote That has stopped working after specific revision to Who Wrote That has stopped working after specific revision (due to local User:Lingzhi2/reviewsourcecheck-sb.js).Oct 16 2023, 9:15 AM

@RoySmith: For future reference, see https://www.mediawiki.org/wiki/Help:Locating_broken_scripts how to test with safemode first - thanks.

MusikAnimal moved this task from Ready 🎬 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.Wed, Apr 10, 4:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL