Page MenuHomePhabricator
Create Task
Maniphest T348927

Add PluggableAuth extension unit tests classes MapGroupsTest and SyncAllGroupsTest to the Database group
Closed, ResolvedPublic
Actions

Description

Some PluggableAuth extension unit tests fail because tests change database content, but the test classes are not in the Database group. Becuase no database prefix is set for such tests, the tests fail with an assertion (error message: "RuntimeException: Can't create user on real database").

Todo: add classes MapGroupsTest and SyncAllGroupsTest to the Database group

See also some related links:
https://www.mediawiki.org/w/index.php?title=Topic:Xredg9711t0eje1m
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OpenIDConnect/+/965852

Details

SubjectRepoBranchLines +/-
Add some unit test classes to Database groupmediawiki/extensions/PluggableAuthREL1_41+6 -0
Add some unit test classes to Database groupmediawiki/extensions/PluggableAuthREL1_40+6 -0
Add some unit test classes to Database groupmediawiki/extensions/PluggableAuthREL1_39+6 -0
Add some unit test classes to Database groupmediawiki/extensions/PluggableAuthmaster+6 -0
Customize query in gerrit

Event Timeline

Vajdaz created this task.Oct 15 2023, 3:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2023, 3:51 PM
Vajdaz moved this task from Backlog to In Progress on the MediaWiki-extensions-OpenID-Connect board.Oct 15 2023, 3:51 PM
Vajdaz updated the task description. (Show Details)Oct 15 2023, 3:59 PM
gerritbot added a comment.Oct 15 2023, 4:04 PM

Change 965913 had a related patch set uploaded (by Vajdaz; author: Vajdaz):

[mediawiki/extensions/PluggableAuth@master] Add some unit test classes to Database group

https://gerrit.wikimedia.org/r/965913

gerritbot added a project: Patch-For-Review.Oct 15 2023, 4:04 PM
gerritbot added a comment.Oct 15 2023, 4:25 PM

Change 965913 merged by jenkins-bot:

[mediawiki/extensions/PluggableAuth@master] Add some unit test classes to Database group

https://gerrit.wikimedia.org/r/965913

CCicalese_WMF closed this task as Resolved.Oct 15 2023, 4:25 PM
CCicalese_WMF moved this task from Backlog to Closed on the MediaWiki-extensions-Pluggable-Auth board.
Maintenance_bot removed a project: Patch-For-Review.Oct 15 2023, 4:30 PM
gerritbot added a comment.Oct 15 2023, 5:13 PM

Change 965893 had a related patch set uploaded (by Cicalese; author: Vajdaz):

[mediawiki/extensions/PluggableAuth@REL1_39] Add some unit test classes to Database group

https://gerrit.wikimedia.org/r/965893

gerritbot added a project: Patch-For-Review.Oct 15 2023, 5:13 PM

Change 965894 had a related patch set uploaded (by Cicalese; author: Vajdaz):

[mediawiki/extensions/PluggableAuth@REL1_40] Add some unit test classes to Database group

https://gerrit.wikimedia.org/r/965894

gerritbot added a comment.Oct 15 2023, 5:14 PM

Change 965895 had a related patch set uploaded (by Cicalese; author: Vajdaz):

[mediawiki/extensions/PluggableAuth@REL1_41] Add some unit test classes to Database group

https://gerrit.wikimedia.org/r/965895

gerritbot added a comment.Oct 15 2023, 5:17 PM

Change 965893 merged by jenkins-bot:

[mediawiki/extensions/PluggableAuth@REL1_39] Add some unit test classes to Database group

https://gerrit.wikimedia.org/r/965893

gerritbot added a comment.Oct 15 2023, 5:19 PM

Change 965894 merged by jenkins-bot:

[mediawiki/extensions/PluggableAuth@REL1_40] Add some unit test classes to Database group

https://gerrit.wikimedia.org/r/965894

gerritbot added a comment.Oct 15 2023, 5:19 PM

Change 965895 merged by jenkins-bot:

[mediawiki/extensions/PluggableAuth@REL1_41] Add some unit test classes to Database group

https://gerrit.wikimedia.org/r/965895

cicalese moved this task from In Progress to Closed on the MediaWiki-extensions-OpenID-Connect board.Oct 15 2023, 5:27 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 15 2023, 5:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL