Page MenuHomePhabricator

Handbook with the documented consistent logging across services
Closed, ResolvedPublic5 Estimated Story Points

Description

Background/Goal

Key task for OKR O 6. KR3

As a software engineer in wme i'd like to have a document specifying the logging standards for the team, so that i can rely on it for my work and guarantee quality of logs.

We have a logging package with a defined API for formatted json logs, in this document i'd expect to have a criteria of what to include and what levels to use in what cases.

Acceptance Criteria

  • Document specifying the teams best practices going forward.
  • Template proposal for the team to discuss

Key Tasks

  • Document specifying the following for logs:
    • What logs levels available
    • Per log level, how and what should the logs be created.
  • Document specifying the following for metrics:
  • Present to the team and iterate given feedback.

Artifacts & Resources

Related Objects

Event Timeline

JArguello-WMF renamed this task from Handbook with the documented consistent logging across services to [needs refinement] Handbook with the documented consistent logging across services.Oct 19 2023, 2:20 PM
REsquito-WMF renamed this task from [needs refinement] Handbook with the documented consistent logging across services to Handbook with the documented consistent logging across services.Oct 20 2023, 1:47 PM
REsquito-WMF updated the task description. (Show Details)

Minor things I'd like to see in this doc:

  • guide on code patterns where we must have logging, optional logging and not use logs
  • The same for tracing
  • Ways to dynamically change the log level and filters out by tags in logs or traces. example:
processors:
  filter/1:
    metrics:
      include:
        match_type: regexp
        metric_names:
          - prefix/.*
          - prefix_.*
        resource_attributes:
          - key: container.name
            value: app_container_1
      exclude:
        match_type: strict
        metric_names:
          - kafka-latency-*
JArguello-WMF updated the task description. (Show Details)
JArguello-WMF set the point value for this task to 5.
E.Enabulele changed the task status from Open to In Progress.Nov 14 2023, 2:00 PM